Uploaded image for project: 'Tapestry'
  1. Tapestry
  2. TAPESTRY-1305

ServiceEncoding needs ability to set the PathInfo variable

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 4.1.2
    • Fix Version/s: 4.1.5
    • Component/s: None
    • Labels:
      None

      Description

      ServiceEncoding does not allow for the _pathInfo member to be changed. I need to do so because I have a encoder that is stripping out a tracking id before the service-specific encoder runs.

        Activity

        Hide
        jkuhnert Jesse Kuhnert added a comment -

        ok

        Show
        jkuhnert Jesse Kuhnert added a comment - ok
        Hide
        patmoore@ieee.org Patrick Moore added a comment -

        looking at 4.1.4 code I don't see a

        public void setPathInfo(String pathInfo)

        did it get added?

        Also need resetModified() on ServiceEncoding as well. This is to handle use case for encoders the decorate the url but are not the final encoding service. If there is a more approved way please let me know..

        Show
        patmoore@ieee.org Patrick Moore added a comment - looking at 4.1.4 code I don't see a public void setPathInfo(String pathInfo) did it get added? Also need resetModified() on ServiceEncoding as well. This is to handle use case for encoders the decorate the url but are not the final encoding service. If there is a more approved way please let me know..
        Hide
        andyhot Andreas Andreou added a comment -

        The resetModified method was already there, but just added a setPathInfo()

        To use both, you need to cast to ServiceEncodingImpl - the ServiceEncoding interface is
        left unchanged for a reason

        Show
        andyhot Andreas Andreou added a comment - The resetModified method was already there, but just added a setPathInfo() To use both, you need to cast to ServiceEncodingImpl - the ServiceEncoding interface is left unchanged for a reason

          People

          • Assignee:
            andyhot Andreas Andreou
            Reporter:
            patmoore@ieee.org Patrick Moore
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development