[TAPESTRY-1301] Class not found with cglib loaded in a parent (non-webapp) classloader. (CglibProxiedPropertyChangeObserverImpl)

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.1.2
• Fix Version/s: 4.1.2
• Component/s: Framework
• Environment: Tomcat 5.5.20
• Assignee: Jesse Kuhnert
• Reporter: Marcus Schulte
• Created: 26/Feb/07 16:23
• Updated: 03/Mar/07 23:08
• Resolved: 03/Mar/07 23:08

Description

We need CGLIB to reside in Tomcat's common/lib Classloader due to Hibernate-Issues.
In this case, there is a ClassNotFoundException from CglibProxiedPropertyChangeObserverImpl.observePropertyChanges().

This is, because net.sf.cglib.proxy.Enhancer's static create-method falls back on the classloader, in which it is loaded. The correct behaviour, imo, would be to make the enhancer use the thread-context-classloader.

Proposed patch (tested, works well):
In o.a.t.record.CglibPropertyChangeInterceptor change the lines (90ff):
_________________
Object ret = Enhancer.create(property.getClass(), interfaces,
new ObservableMethodFilter(),
new Callback[]

{ new LazyProxyDelegate(property), new CglibPropertyChangeInterceptor(component, property, propertyName)}

);
_______________

into:
______________________
Enhancer e = new Enhancer();
e.setClassLoader( Thread.currentThread().getContextClassLoader() );
e.setSuperclass(property.getClass());
e.setInterfaces(interfaces);
e.setCallbackFilter(new ObservableMethodFilter());
e.setCallbacks(new Callback[]

{ new LazyProxyDelegate(property), new CglibPropertyChangeInterceptor(component, property, propertyName)}

);
Object ret = e.create();
________________________