Tapestry
  1. Tapestry
  2. TAPESTRY-1245

Alter LinkSubmit to output javascript in onclick (instead of in href)

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.1.1
    • Fix Version/s: 4.1.2
    • Component/s: tapestry-core
    • Labels:
      None

      Description

      i'd prefer not to use the href attribute for this. It's semantically incorrect, the status-bar gets ugly, phone browsers dislike it, e.t.c.

      Even better, don't output any javascript inside the link tag - have the html clean and hava dojo wire up the onclick event

        Activity

        Hide
        Jesse Kuhnert added a comment -

        As you wish.

        Show
        Jesse Kuhnert added a comment - As you wish.
        Hide
        Marcus Schulte added a comment -

        It also prevents dirty-form-checkers from working correctly in Internet Explorer.

        Show
        Marcus Schulte added a comment - It also prevents dirty-form-checkers from working correctly in Internet Explorer.
        Hide
        Kristian Marinkovic added a comment -

        +1 for adding events via dojo.connect

        Show
        Kristian Marinkovic added a comment - +1 for adding events via dojo.connect

          People

          • Assignee:
            Jesse Kuhnert
            Reporter:
            Andreas Andreou
          • Votes:
            2 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development