Tapestry
  1. Tapestry
  2. TAPESTRY-1245

Alter LinkSubmit to output javascript in onclick (instead of in href)

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.1.1
    • Fix Version/s: 4.1.2
    • Component/s: tapestry-core
    • Labels:
      None

      Description

      i'd prefer not to use the href attribute for this. It's semantically incorrect, the status-bar gets ugly, phone browsers dislike it, e.t.c.

      Even better, don't output any javascript inside the link tag - have the html clean and hava dojo wire up the onclick event

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        116d 6h 11m 1 Jesse Kuhnert 28/May/07 19:31
        Mark Thomas made changes -
        Workflow Default workflow, editable Closed status [ 12568113 ] jira [ 12591204 ]
        Mark Thomas made changes -
        Workflow jira [ 12395521 ] Default workflow, editable Closed status [ 12568113 ]
        Jesse Kuhnert made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Assignee Jesse Kuhnert [ jkuhnert ]
        Hide
        Jesse Kuhnert added a comment -

        As you wish.

        Show
        Jesse Kuhnert added a comment - As you wish.
        Hide
        Marcus Schulte added a comment -

        It also prevents dirty-form-checkers from working correctly in Internet Explorer.

        Show
        Marcus Schulte added a comment - It also prevents dirty-form-checkers from working correctly in Internet Explorer.
        Hide
        Kristian Marinkovic added a comment -

        +1 for adding events via dojo.connect

        Show
        Kristian Marinkovic added a comment - +1 for adding events via dojo.connect
        Andreas Andreou made changes -
        Field Original Value New Value
        Fix Version/s 4.1.2 [ 12312202 ]
        Andreas Andreou created issue -

          People

          • Assignee:
            Jesse Kuhnert
            Reporter:
            Andreas Andreou
          • Votes:
            2 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development