Tapestry
  1. Tapestry
  2. TAPESTRY-1203

boolean.getBoolean doesn't work as expected in InjectMetaWorker

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.1.1
    • Fix Version/s: 4.1.2
    • Component/s: Framework
    • Labels:
      None

      Description

      In InjectMetaWorker Boolean.getBoolean(String name) is used to convert strings to primitive booleans. However, this method converts the value of a system property given name to boolean, not the value of the string itself. Boolean.parseBoolean is more correct but only available is JDK 1.5

      This might be a regression bug from TAPESTRY-902

      It was changed a few months ago.
      http://svn.apache.org/viewvc/tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/enhance/InjectMetaWorker.java?r1=419064&r2=483838&diff_format=h

      Thanks,
      Darren.

        Issue Links

          Activity

          Hide
          Jesse Kuhnert added a comment -

          Now correctly using "java.lang.Boolean.valueOf(string).booleanValue()" . Thanks for the report, sorry for the goof up.

          Show
          Jesse Kuhnert added a comment - Now correctly using "java.lang.Boolean.valueOf(string).booleanValue()" . Thanks for the report, sorry for the goof up.

            People

            • Assignee:
              Jesse Kuhnert
              Reporter:
              Darren Gilroy
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development