Tapestry
  1. Tapestry
  2. TAPESTRY-1182

make ComponentAnnotationWorker extensible

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.1.1
    • Fix Version/s: 4.1.2
    • Component/s: Annotations
    • Labels:
      None

      Description

      I'm working on an implementation of global namespaces for Tapestry 4.1. It would solve some of the problems with libraries and namespaces. The implementation is almost done (but there are no docs yet... ).

      To make my library more easier to use, I'd like to extend ComponentAnnotationWorker to be able to automatically lookup components in the global namespace.
      For this to work, the following changes are required:

      • ComponentAnnotationWorker should be a hivemind service to be overridable
      • the automatic component type resolution algorithm should go to a separate method to make it easier to reuse the class as a superclass

      I will release the library only if this change is applied to the annotation codebase, because it is a requirement for one of the most important functions of the library.
      It would be great if this change could be part of the final 4.1.1!

      Thanks for your help!
      Regards,
      Norbi

      1. patch.txt
        2 kB
        Norbert Sándor

        Activity

        Norbert Sándor created issue -
        Hide
        Norbert Sándor added a comment -

        SVN patch of my implementation.

        Show
        Norbert Sándor added a comment - SVN patch of my implementation.
        Norbert Sándor made changes -
        Field Original Value New Value
        Attachment patch.txt [ 12346938 ]
        Jesse Kuhnert made changes -
        Fix Version/s 4.1.1 [ 12312021 ]
        Hide
        Jesse Kuhnert added a comment -

        Ok patch applied.

        Show
        Jesse Kuhnert added a comment - Ok patch applied.
        Jesse Kuhnert made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Norbert Sándor added a comment -

        I don't see this fix in 4.1.1...
        Am I missing something?

        Show
        Norbert Sándor added a comment - I don't see this fix in 4.1.1... Am I missing something?
        Hide
        Norbert Sándor added a comment -

        My patch was applied only partially. The hivemodule.xml file was not patched...

        ;(

        Show
        Norbert Sándor added a comment - My patch was applied only partially. The hivemodule.xml file was not patched... ;(
        Jesse Kuhnert made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Jesse Kuhnert made changes -
        Assignee Jesse Kuhnert [ jkuhnert ]
        Fix Version/s 4.1.1 [ 12312021 ]
        Fix Version/s 4.1.2 [ 12312202 ]
        Hide
        Jesse Kuhnert added a comment -

        Oops...Didn't notice an svn conflict rejection on that one.

        Show
        Jesse Kuhnert added a comment - Oops...Didn't notice an svn conflict rejection on that one.
        Jesse Kuhnert made changes -
        Resolution Fixed [ 1 ]
        Status Reopened [ 4 ] Resolved [ 5 ]
        Mark Thomas made changes -
        Workflow jira [ 12392109 ] Default workflow, editable Closed status [ 12567986 ]
        Mark Thomas made changes -
        Workflow Default workflow, editable Closed status [ 12567986 ] jira [ 12591097 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        3d 22h 55m 1 Jesse Kuhnert 15/Dec/06 19:15
        Resolved Resolved Reopened Reopened
        6d 2h 30m 1 Jesse Kuhnert 21/Dec/06 21:45
        Reopened Reopened Resolved Resolved
        16m 6s 1 Jesse Kuhnert 21/Dec/06 22:01

          People

          • Assignee:
            Jesse Kuhnert
            Reporter:
            Norbert Sándor
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development