Uploaded image for project: 'Tapestry'
  1. Tapestry
  2. TAPESTRY-1182

make ComponentAnnotationWorker extensible

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 4.1.1
    • Fix Version/s: 4.1.2
    • Component/s: Annotations
    • Labels:
      None

      Description

      I'm working on an implementation of global namespaces for Tapestry 4.1. It would solve some of the problems with libraries and namespaces. The implementation is almost done (but there are no docs yet... ).

      To make my library more easier to use, I'd like to extend ComponentAnnotationWorker to be able to automatically lookup components in the global namespace.
      For this to work, the following changes are required:

      • ComponentAnnotationWorker should be a hivemind service to be overridable
      • the automatic component type resolution algorithm should go to a separate method to make it easier to reuse the class as a superclass

      I will release the library only if this change is applied to the annotation codebase, because it is a requirement for one of the most important functions of the library.
      It would be great if this change could be part of the final 4.1.1!

      Thanks for your help!
      Regards,
      Norbi

      1. patch.txt
        2 kB
        Norbert Sándor

        Activity

        Hide
        jkuhnert Jesse Kuhnert added a comment -

        Oops...Didn't notice an svn conflict rejection on that one.

        Show
        jkuhnert Jesse Kuhnert added a comment - Oops...Didn't notice an svn conflict rejection on that one.
        Hide
        snorbi Norbert Sándor added a comment -

        My patch was applied only partially. The hivemodule.xml file was not patched...

        ;(

        Show
        snorbi Norbert Sándor added a comment - My patch was applied only partially. The hivemodule.xml file was not patched... ;(
        Hide
        snorbi Norbert Sándor added a comment -

        I don't see this fix in 4.1.1...
        Am I missing something?

        Show
        snorbi Norbert Sándor added a comment - I don't see this fix in 4.1.1... Am I missing something?
        Hide
        jkuhnert Jesse Kuhnert added a comment -

        Ok patch applied.

        Show
        jkuhnert Jesse Kuhnert added a comment - Ok patch applied.
        Hide
        snorbi Norbert Sándor added a comment -

        SVN patch of my implementation.

        Show
        snorbi Norbert Sándor added a comment - SVN patch of my implementation.

          People

          • Assignee:
            jkuhnert Jesse Kuhnert
            Reporter:
            snorbi Norbert Sándor
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development