Tapestry
  1. Tapestry
  2. TAPESTRY-1180

synchronizeWidgetState doesn't allow position to be used

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 4.1.1
    • Fix Version/s: 4.1.1
    • Component/s: JavaScript
    • Labels:
      None

      Description

      tapestry.widget.synchronizeWidgetState calls on Dojo's createWidget, which takes a parameter specifying where the widget should be placed in relation to the DOM node. However, synchroniseWidgetState does not take this parameter, so the positioning functionality is unavailable.

        Activity

        Mark Thomas made changes -
        Workflow Default workflow, editable Closed status [ 12567979 ] jira [ 12591092 ]
        Mark Thomas made changes -
        Workflow jira [ 12391976 ] Default workflow, editable Closed status [ 12567979 ]
        Jesse Kuhnert made changes -
        Resolution Fixed [ 1 ]
        Status Open [ 1 ] Resolved [ 5 ]
        Hide
        Jesse Kuhnert added a comment -

        Fix made, thanks.

        FYI there were two problems with the patch:

        -) It referenced a file with a different name than what is in the apache repo

        -) It referenced the file directly as in "something/<foo>Widget.js" instead of "tapestry/tapestry-framework/src/js/tapestry/widget/Widget.js" .

        Not that I'm not grateful for the fix, just thought you should know for future patches. (if any)

        Show
        Jesse Kuhnert added a comment - Fix made, thanks. FYI there were two problems with the patch: -) It referenced a file with a different name than what is in the apache repo -) It referenced the file directly as in "something/<foo>Widget.js" instead of "tapestry/tapestry-framework/src/js/tapestry/widget/Widget.js" . Not that I'm not grateful for the fix, just thought you should know for future patches. (if any)
        Jesse Kuhnert made changes -
        Fix Version/s 4.1.1 [ 12312021 ]
        Phil McCarthy made changes -
        Field Original Value New Value
        Attachment widget-position.patch [ 12346837 ]
        Hide
        Phil McCarthy added a comment -

        Patch to widget.js that allows Widget position to be specified relative to widget DOM node.

        Show
        Phil McCarthy added a comment - Patch to widget.js that allows Widget position to be specified relative to widget DOM node.
        Phil McCarthy created issue -

          People

          • Assignee:
            Unassigned
            Reporter:
            Phil McCarthy
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development