Tapestry
  1. Tapestry
  2. TAPESTRY-1061

AssetService doesn't translate paths relative to CSS file.

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 4.1.1
    • Fix Version/s: 4.1.1
    • Component/s: None
    • Labels:
      None

      Description

      The AssertService.translatePath method doesn't deal properly with paths like
      "/dojo/src/widget/template/HtmlComboBox.css../images/foo.gif"

      The first ".." relative to the CSS file is not removed & so the asset is not found if it is in a jar.

      Currently the result is
      "/dojo/src/widget/template/../images/foo.gif"

      When it should be
      "/dojo/src/widget/images/foo.gif"

      1. TAP-1061.patch
        4 kB
        Ben Sommerville

        Issue Links

          Activity

          Hide
          Jesse Kuhnert added a comment -

          Patch applied, thanks! =)

          Show
          Jesse Kuhnert added a comment - Patch applied, thanks! =)
          Hide
          Ben Sommerville added a comment -

          Patch that fixes problem.

          Moved the normalization of the path to after it has been processed for relative CSS includes.
          This seems to catch all the cases I could think of.

          Show
          Ben Sommerville added a comment - Patch that fixes problem. Moved the normalization of the path to after it has been processed for relative CSS includes. This seems to catch all the cases I could think of.

            People

            • Assignee:
              Jesse Kuhnert
              Reporter:
              Ben Sommerville
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development