Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.1.1
    • Fix Version/s: 4.1.1
    • Component/s: None
    • Labels:
      None
    • Environment:
      tapestry 4.1.1

      Description

      in tapestry.form.validator.Pattern

      private String buildMessage(ValidationMessages messages, IFormComponent field)
      {
      return messages.formatValidationMessage(
      getMessage(),
      ValidationStrings.REGEX_MISMATCH,
      new Object[]

      { _pattern, field.getDisplayName() }

      );
      }

      In ValidationStrings.properties

      regex-mismatch=

      {0}

      is invalid.

      so the message is ${_pattern} is valid.I think the message should be $

      {field.getDisplayName()}

      is invalid.

        Activity

        Jun Tsai created issue -
        Hide
        Jun Tsai added a comment -

        I think the buildMessage method should be
        private String buildMessage(ValidationMessages messages, IFormComponent field)
        {
        return messages.formatValidationMessage(
        getMessage(),
        ValidationStrings.REGEX_MISMATCH,
        new Object[]

        { field.getDisplayName() , _pattern}

        );
        }

        Show
        Jun Tsai added a comment - I think the buildMessage method should be private String buildMessage(ValidationMessages messages, IFormComponent field) { return messages.formatValidationMessage( getMessage(), ValidationStrings.REGEX_MISMATCH, new Object[] { field.getDisplayName() , _pattern} ); }
        Hide
        Jesse Kuhnert added a comment -

        Fixed, thanks. That particular validator should have actually been using the PATTERN_MISMATCH message instead of the REGEXP_MISMATCH msg.

        Show
        Jesse Kuhnert added a comment - Fixed, thanks. That particular validator should have actually been using the PATTERN_MISMATCH message instead of the REGEXP_MISMATCH msg.
        Jesse Kuhnert made changes -
        Field Original Value New Value
        Fix Version/s 4.1.1 [ 12312021 ]
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Mark Thomas made changes -
        Workflow jira [ 12379612 ] Default workflow, editable Closed status [ 12567841 ]
        Mark Thomas made changes -
        Workflow Default workflow, editable Closed status [ 12567841 ] jira [ 12590970 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Jun Tsai
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development