[TAP5-961] When a URL rewriting rule changes the path for a rendered link (component event or page render), any query parameters associated with the original link are lost

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 5.1.0.5
• Fix Version/s: 5.2.0
• Component/s: tapestry-core
• Assignee: Howard Lewis Ship
• Reporter: Richard Bolkey
• Created: 29/Dec/09 19:37
• Updated: 28/Jul/10 10:27
• Resolved: 23/Feb/10 20:37

Description

When a link is rewritten that contains parameters, the parameter information is not passed along to the newly created link. This creates a problem, for example, when the activation context "t:ac" is specified as a parameter in event links.

Link rewriteIfNeeded(Link link, URLRewriteContext context)
{
Link newLink = null;
SimpleRequestWrapper fakeRequest = new SimpleRequestWrapper(request, link.toAbsoluteURI());

Request rewritten = urlRewriter.processLink(fakeRequest,context);

// if the original request is equal to the rewritten one, no
// rewriting is needed
if (fakeRequest != rewritten)

{ final String originalServerName = request.getServerName(); final String rewrittenServerName = rewritten.getServerName(); boolean absolute = originalServerName.equals(rewrittenServerName) == false; final String newPath = rewritten.getPath(); String newUrl = absolute ? fullUrl(rewritten) : newPath; newLink = new LinkImpl(newUrl, false, false, response, null); (edit: ** newLink needs parameter information specified here) }

return newLink;

}

Issue Links

• is duplicated by: TAP5-1194 ComponentEventLinkEncoder omits original Link's parameters when URL Rewriting has been applied.