Uploaded image for project: 'Tapestry 5'
  1. Tapestry 5
  2. TAP5-945

Unnecessary and severe lock contention in PerthreadManagerImpl

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 5.1.0.5
    • 5.2.0
    • tapestry-core
    • None

    Description

      When load testing our new high-volume site before soft launch, we found that we have severe lock contention in org.apache.tapestry5.ioc.internal.services.PerthreadManagerImpl.

      It synchronizes on "this" before invoking ThreadLocal.get() and ThreadLocal.remove(), which I believe is unnecessary.

      During our tests, approximately 35% of all Tomcat threads were waiting for this lock in any of 10 thread dumps taken 15 seconds apart.

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. TAPESTRY-2141 NullPointerExceptions under JDK 1.5 due to underlying ThreadLocal bug

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. TAP5-946 Unnecessary synchronization in PerThreadOperationTracker

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Activity

            People

              hlship Howard Lewis Ship
              hitoha Olle Hallin
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: