Uploaded image for project: 'Tapestry 5'
  1. Tapestry 5
  2. TAP5-760

The Form event "validateForm" is awkwardly named and should be replaced with the simpler name "validate"

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 5.1.0.5
    • Fix Version/s: 5.2.0
    • Component/s: tapestry-core
    • Labels:
      None

      Description

      You end up with methods like onValidateFormFromLogin() which is just asking for trouble.

      onFormValidateFromLogin() is a bit better.

      Obviously, we keep the old name as well ... have to fire two events at the validate form stage.

      What would be a better name? Something that doesn't have "form" is it; perhaps "finalValidation" or just "validate". I remember this was a problem with calling it "validate" before, because this conflicted with the validate event form form control element components ... but is that really a problem?

        Attachments

          Activity

            People

            • Assignee:
              hlship Howard M. Lewis Ship
              Reporter:
              hlship Howard M. Lewis Ship
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: