Tapestry 5
  1. Tapestry 5
  2. TAP5-698

PageTester's setupRequestFromURI incorrectly uses substring twice on same string

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 5.1.0.5
    • Fix Version/s: 5.3
    • Component/s: tapestry-test
    • Labels:
      None

      Description

      Incoming linkPath: /filelist.delete/c$002ftest2-2510777506787452085.txt?t:ac=c
      int comma is set to 52
      path: /filelist.delete/c$002ftest2-2510777506787452085.txt
      then trying to do a path.substring(comma+1)

      Fix: use linkPath instead of path at line 304:

      if (comma > 0)
      decodeParametersIntoRequest(path.substring(comma + 1));

        Issue Links

          Activity

          Hide
          Hudson added a comment -

          Integrated in tapestry-trunk-freestyle #585 (See https://builds.apache.org/job/tapestry-trunk-freestyle/585/)
          TAP5-698: PageTester's setupRequestFromURI incorrectly uses substring twice on same string

          hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1185926
          Files :

          • /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/test/PageTester.java
          Show
          Hudson added a comment - Integrated in tapestry-trunk-freestyle #585 (See https://builds.apache.org/job/tapestry-trunk-freestyle/585/ ) TAP5-698 : PageTester's setupRequestFromURI incorrectly uses substring twice on same string hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1185926 Files : /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/test/PageTester.java

            People

            • Assignee:
              Howard M. Lewis Ship
              Reporter:
              Chris Wilkes
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development