Tapestry 5
  1. Tapestry 5
  2. TAP5-630

Blackbird error console class names are too generic and can easily conflict

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 5.1.0.2
    • Fix Version/s: 5.1.0.3
    • Component/s: tapestry-core
    • Labels:
      None

      Description

      Blackbird error console class names are too generic and can easily conflict with those used by Tapestry designers. e.g. header, left, filters.

        Activity

        Hide
        Andy Blower added a comment -

        This is what I saw when I got an issue on our results page. We have a class called 'filters' for our search results filter panel.

        Show
        Andy Blower added a comment - This is what I saw when I got an issue on our results page. We have a class called 'filters' for our search results filter panel.
        Hide
        Howard M. Lewis Ship added a comment -

        Hm. Ugly. I think that the blackbird.css came earlier in the document that your applications' stylesheet, and it redefined some of the CSS styles used by blackbird, out from under it. The blackbird CSS is qualified to prevent the opposite from happening. I'm adding "t-" prefixes to the CSS selector names ("header", "footer", "left", "right", "main", "filter") that are most likely to conflict.

        Show
        Howard M. Lewis Ship added a comment - Hm. Ugly. I think that the blackbird.css came earlier in the document that your applications' stylesheet, and it redefined some of the CSS styles used by blackbird, out from under it. The blackbird CSS is qualified to prevent the opposite from happening. I'm adding "t-" prefixes to the CSS selector names ("header", "footer", "left", "right", "main", "filter") that are most likely to conflict.

          People

          • Assignee:
            Howard M. Lewis Ship
            Reporter:
            Andy Blower
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development