Tapestry 5
  1. Tapestry 5
  2. TAP5-584

Omit generator meta (from head element) when root element is not html

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 5.1.0.2
    • Fix Version/s: 5.1.0.2
    • Component/s: tapestry-core
    • Labels:
      None

      Description

      When using tapestry to generate xml which is not xhtml, the generator meta should be omitted. Currently tapestry will add a head and generator meta to every root element if the SymbolConstants.OMIT_GENERATOR_META == false.

      Solution: check if the root element name is html, if not, don't add even with SymbolConstants.OMIT_GENERATOR_META == false.

      1. TAP-584_patch.txt
        2 kB
        Joost Schouten

        Activity

        Hide
        Joost Schouten added a comment -

        Patch fixing the problem. Also added a test to check that the head and meta are not added if the root element is not html

        Show
        Joost Schouten added a comment - Patch fixing the problem. Also added a test to check that the head and meta are not added if the root element is not html
        Hide
        Howard M. Lewis Ship added a comment -

        I'll add the patch since this is simple, but in general, a patch without tests is a problem.

        Show
        Howard M. Lewis Ship added a comment - I'll add the patch since this is simple, but in general, a patch without tests is a problem.
        Hide
        Howard M. Lewis Ship added a comment -

        Shame on me, not fully awake! I see the test, bravo!

        Show
        Howard M. Lewis Ship added a comment - Shame on me, not fully awake! I see the test, bravo!

          People

          • Assignee:
            Howard M. Lewis Ship
            Reporter:
            Joost Schouten
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development