Tapestry 5
  1. Tapestry 5
  2. TAP5-500

Small typo in javadoc comments for Cookies service.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 5.1.0.0, 5.1, 5.0.18, 5.0.19
    • Fix Version/s: 5.1.0.4
    • Component/s: tapestry-core
    • Labels:
      None

      Description

      Small typo in javadoc comments for Cookies service.

      1. patch
        1 kB
        Massimo Lusetti

        Activity

        Hide
        Massimo Lusetti added a comment -

        Very simple patch

        Show
        Massimo Lusetti added a comment - Very simple patch
        Hide
        Ulrich Stärk added a comment -

        Maybe you should just tell the devs what the typo is. I believe it's faster to fix it manually than downloading and applying your patch.

        Uli

        Show
        Ulrich Stärk added a comment - Maybe you should just tell the devs what the typo is. I believe it's faster to fix it manually than downloading and applying your patch. Uli
        Hide
        Massimo Lusetti added a comment -

        Strange complaints, anyway here is the diff.

        Index: tapestry-project/tapestry-core/src/main/java/org/apache/tapestry5/services/Cookies.java
        ===================================================================
        — tapestry-project/tapestry-core/src/main/java/org/apache/tapestry5/services/Cookies.java (revision 741470)
        +++ tapestry-project/tapestry-core/src/main/java/org/apache/tapestry5/services/Cookies.java (working copy)
        @@ -52,17 +52,17 @@
        void writeCookieValue(String name, String value, String path);

        /**

        • * As with {@link #writeCookieValue(String, String)} but an explicit path may be set.
          + * As with {@link #writeCookieValue(String, String)}

          but an explicit domain may be set.
          */
          void writeDomainCookieValue(String name, String value, String domain);

        /**

        • * As with {@link #writeCookieValue(String, String)} but an explicit path may be set.
          + * As with {@link #writeCookieValue(String, String)}

          but an explicit domain and maximum age may be set.
          */
          void writeDomainCookieValue(String name, String value, String domain, int maxAge);

        /**

        • * As with {@link #writeCookieValue(String, String, String)} but an explicit domain may be set.
          + * As with {@link #writeCookieValue(String, String, String)}

          but an explicit domain and path may be set.
          */
          void writeCookieValue(String name, String value, String path, String domain);

        Show
        Massimo Lusetti added a comment - Strange complaints, anyway here is the diff. Index: tapestry-project/tapestry-core/src/main/java/org/apache/tapestry5/services/Cookies.java =================================================================== — tapestry-project/tapestry-core/src/main/java/org/apache/tapestry5/services/Cookies.java (revision 741470) +++ tapestry-project/tapestry-core/src/main/java/org/apache/tapestry5/services/Cookies.java (working copy) @@ -52,17 +52,17 @@ void writeCookieValue(String name, String value, String path); /** * As with {@link #writeCookieValue(String, String)} but an explicit path may be set. + * As with {@link #writeCookieValue(String, String)} but an explicit domain may be set. */ void writeDomainCookieValue(String name, String value, String domain); /** * As with {@link #writeCookieValue(String, String)} but an explicit path may be set. + * As with {@link #writeCookieValue(String, String)} but an explicit domain and maximum age may be set. */ void writeDomainCookieValue(String name, String value, String domain, int maxAge); /** * As with {@link #writeCookieValue(String, String, String)} but an explicit domain may be set. + * As with {@link #writeCookieValue(String, String, String)} but an explicit domain and path may be set. */ void writeCookieValue(String name, String value, String path, String domain);

          People

          • Assignee:
            Howard M. Lewis Ship
            Reporter:
            Massimo Lusetti
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development