Tapestry 5
  1. Tapestry 5
  2. TAP5-49

Grid.defaultModel() should be a protected method so that subclasses can override the default BeanModel logic

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 5.0.15
    • Fix Version/s: 5.0.16
    • Component/s: None
    • Labels:
      None
    • Environment:
      All

      Description

      For a sub-class of Grid, it's impossible to provide its own BeanModel to override the default model in Grid because the method
      Binding defaultModel()

      {..}

      is package visible.

      it would be nice to have that method to be protected to let sub-class of Grid be able to override the default model.

      I know a workaround is to make a component to composite the Grid, bind model parameter to a property and copy all the parameters over; but there are so many parameters in Grid component, I don't think it's a good way.

      Thanks,
      Yunhua

        Activity

        Howard M. Lewis Ship made changes -
        Fix Version/s 5.0.16 [ 12313427 ]
        Status In Progress [ 3 ] Closed [ 6 ]
        Resolution Fixed [ 1 ]
        Howard M. Lewis Ship made changes -
        Summary It's impossible to override default model in subclass of Grid Grid.defaultModel() should be a protected method so that subclasses can override the default BeanModel logic
        Issue Type Bug [ 1 ] Improvement [ 4 ]
        Howard M. Lewis Ship made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Howard M. Lewis Ship made changes -
        Assignee Howard M. Lewis Ship [ hlship ]
        Hide
        Howard M. Lewis Ship added a comment -

        I'm not sure I ever expected a parameter default method, such as defaultModel(), to be overridable in a subclass. It should work, so I'll see about easing the visiblility.

        Show
        Howard M. Lewis Ship added a comment - I'm not sure I ever expected a parameter default method, such as defaultModel(), to be overridable in a subclass. It should work, so I'll see about easing the visiblility.
        Howard M. Lewis Ship made changes -
        Affects Version/s 5.0.15 [ 12313429 ]
        Howard M. Lewis Ship made changes -
        Field Original Value New Value
        Key TAPESTRY-2608 TAP5-49
        Project Tapestry [ 10573 ] Tapestry 5 [ 12310833 ]
        Issue Type Improvement [ 4 ] Bug [ 1 ]
        Affects Version/s 5.0.14 [ 12313214 ]
        Component/s tapestry-core [ 12311285 ]
        Yunhua Sang created issue -

          People

          • Assignee:
            Howard M. Lewis Ship
            Reporter:
            Yunhua Sang
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development