[TAP5-355] TapestrySpring does not support injection of Spring FactoryBeans

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 5.1.0.0
• Component/s: tapestry-spring
• Environment: Spring 2.5.5
• Assignee: Howard Lewis Ship
• Reporter: Phil Zoio
• Created: 08/Oct/08 11:13
• Updated: 08/Jan/09 19:43
• Resolved: 08/Jan/09 19:43

Description

This applies as of the released 5.0.16.

SpringModuleDef uses BeanFactoryUtils.beanNamesIncludingAncestors(context) to get the list of bean names to inject into Tapestry service registry.

For factory beans, this method returns the bean name prefixed by &

Later calls to context.getBean() using this name return the factory bean instance, rather than the target object needed by the application.

Suggested fix:

Replace

for (final String beanName : BeanFactoryUtils.beanNamesIncludingAncestors(context))
{

with

for (final String candidate : BeanFactoryUtils.beanNamesIncludingAncestors(context))
{
final String beanName = (candidate.startsWith("&", candidate.subString(1), candidate);