[TAP5-2753] CssCompressor for CSS files produces wrong minification if calc contains variables.

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 5.8.2
• Fix Version/s: 5.8.3
• Component/s: tapestry-webresources
• Assignee: Ben Weidig
• Reporter: LRein
• Created: 06/Apr/23 17:51
• Updated: 26/Jun/23 07:48
• Resolved: 26/Jun/23 07:48

Description

CssCompressor for CSS files produces wrong minification if calc contains variables.

.some-class
{
padding-top: calc(10px + var(--default-page-header-height));
}

produces spaces between dashes within the variable:

.some-class
{
padding-top: calc(10px + var( - - default - page - header - height));
}

Just removing this code block at the end helps:

// Add spaces back in between operators for css calc function
// https://developer.mozilla.org/en-US/docs/Web/CSS/calc
// Added by Eric Arnol-Martin ([e-mail])
sb = new StringBuffer();
p = Pattern.compile("calc\\([^\\)]*\\)");
m = p.matcher(css);
while (m.find()) {
    String s = m.group();
    
    s = s.replaceAll("(?<=[-|%|px|em|rem|vw|\\d]+)\\+", " + ");
    s = s.replaceAll("(?<=[-|%|px|em|rem|vw|\\d]+)\\-", " - ");
    s = s.replaceAll("(?<=[-|%|px|em|rem|vw|\\d]+)\\*", " * ");
    s = s.replaceAll("(?<=[-|%|px|em|rem|vw|\\d]+)\\/", " / ");
    
    m.appendReplacement(sb, s);
}
m.appendTail(sb);
css = sb.toString(); 

Issue Links

• is related to: TAP5-2708 CssCompressor update/optimizations