[TAP5-2735] LocalizationSetter should add "void setLocaleFromRequest(Request)"

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 5.8.2
• Fix Version/s: 5.8.3
• Component/s: tapestry-core
• Assignee: Ben Weidig
• Reporter: Ben Weidig
• Created: 19/Jun/22 14:39
• Updated: 16/Jul/23 22:21
• Resolved: 28/Aug/22 14:15

Description

The LocalizationSetter is responsible for setting the correct Locale and provides an excellent extension/override point if you want to affect that, like we do in a multi-tenant/multi-language application.

But component events fallback to the Request Locale if no other is available, which leads to wrong Locale detection in our case.
The responsible void setLocaleFromRequest(Request) is a private method in org.apache.tapestry5.internal.services.ComponentEventLinkEncoderImpl which is not correct IMO.

I propose moving the related code to the LocalizationSetter, so all Locale-related code is in a single interface and therefore modifiable by contributing a custom one.

Issue Links

• mentioned in: Page Loading...