[TAP5-272] File uploads that exceed the upload limit throw an uncatchable exception; Tapestry should notify the page about the exception

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 5.0.16
• Environment: Windows XP, Java 1.6, Sun Java Application Server 9.1
• Assignee: Howard Lewis Ship
• Reporter: Joel Wiegman
• Created: 07/Oct/08 16:34
• Updated: 14/Oct/14 06:42
• Resolved: 19/Nov/08 17:53

Description

When including the following code in my app module to limit file size on an upload:

public void contributeApplicationDefaults(MappedConfiguration<String, String> configuration)

{ configuration.add(UploadSymbols.FILESIZE_MAX, "1500000"); }

An following internal Tapestry exception gets thrown to the application server VM, which is of course uncatchable in application code.

[#|2008-10-07T12:27:17.904-0400|SEVERE|Servlet.service() for servlet default threw exception
java.lang.RuntimeException: Unable to decode multipart encoded request.
at org.apache.tapestry5.upload.internal.services.MultipartDecoderImpl.parseRequest(MultipartDecoderImpl.java:116)
at org.apache.tapestry5.upload.internal.services.MultipartDecoderImpl.decode(MultipartDecoderImpl.java:94)
at $MultipartDecoder_11cd7ca67c8.decode($MultipartDecoder_11cd7ca67c8.java)
at $MultipartDecoder_11cd7ca668e.decode($MultipartDecoder_11cd7ca668e.java)
at org.apache.tapestry5.upload.internal.services.MultipartServletRequestFilter.service(MultipartServletRequestFilter.java:41)
at $HttpServletRequestHandler_11cd7ca6691.service($HttpServletRequestHandler_11cd7ca6691.java)
at org.apache.tapestry5.internal.services.IgnoredPathsFilter.service(IgnoredPathsFilter.java:62)
at $HttpServletRequestFilter_11cd7ca668f.service($HttpServletRequestFilter_11cd7ca668f.java)
at $HttpServletRequestHandler_11cd7ca6691.service($HttpServletRequestHandler_11cd7ca6691.java)
at $HttpServletRequestHandler_11cd7ca668d.service($HttpServletRequestHandler_11cd7ca668d.java)
at org.apache.tapestry5.TapestryFilter.doFilter(TapestryFilter.java:177)
......
Caused by: org.apache.commons.fileupload.FileUploadBase$FileSizeLimitExceededException: The field fileToUpload exceeds its maximum permitted size of 1500000 characters.
at org.apache.commons.fileupload.FileUploadBase$FileItemIteratorImpl$FileItemStreamImpl$1.raiseError(FileUploadBase.java:645)
at org.apache.commons.fileupload.util.LimitedInputStream.checkLimit(LimitedInputStream.java:71)
at org.apache.commons.fileupload.util.LimitedInputStream.read(LimitedInputStream.java:128)
at java.io.FilterInputStream.read(FilterInputStream.java:90)
at org.apache.commons.fileupload.util.Streams.copy(Streams.java:94)
at org.apache.commons.fileupload.util.Streams.copy(Streams.java:64)
at org.apache.commons.fileupload.FileUploadBase.parseRequest(FileUploadBase.java:354)
at org.apache.commons.fileupload.servlet.ServletFileUpload.parseRequest(ServletFileUpload.java:126)
at org.apache.tapestry5.upload.internal.services.MultipartDecoderImpl.parseRequest(MultipartDecoderImpl.java:112)
... 61 more

Issue Links

• is related to: TAP5-2394 onUploadException doesn't work in Components