[TAP5-2640] tapestry-json improvements (implement Collection/Map, better exceptions)

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 5.6.2, 5.7.0
• Component/s: tapestry-json
• Assignee: Ben Weidig
• Reporter: Ben Weidig
• Created: 06/Sep/20 09:39
• Updated: 11/Feb/21 21:56
• Resolved: 11/Feb/21 21:56

Description

As laid out in http://mail-archives.apache.org/mod_mbox/tapestry-dev/202007.mbox/browser these patches aim to improve tapestry-json.

Core features:

• JSONArray/JSONObject implements Collection/Map
• Better exceptions

Unit-tests were added if appropiate. "Passthrough"-methods to the underlying storage weren't tested if there are no additional edge-cases.

Javadoc was added, trying to mimic Collection/Map, but reduced to the actual exception cases.

Minar/breaking changes occur as discussed on the mailing list:

• Signature change: JSONObject get(Object name) instead of JSONObject get(String name)
• Return type / Signature change: void putAll(Map<? extends String, ? extends Object> newProperties) instead of JSONObject putAll(Map<String, ?> newProperties)

I've attached 21 patch files. Maybe I should've squashed it, but if anyone is interested in the evolution/idea behind the code, this way it would be easier to grasp it.

The code is also available on Github https://github.com/apache/tapestry-5/compare/master...benweidig:feature/tapestry-json-exceptions

Issue Links

• mentioned in: Page Loading...