[TAP5-2537] ApplicationStateManagerImpl.getIfExists() fails when session is invalid (on Jetty, at least)

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 5.4
• Fix Version/s: 5.4.1
• Component/s: tapestry-core
• Assignee: Volker Lamp
• Reporter: I D
• Created: 03/Mar/16 19:10
• Updated: 07/Jul/23 06:53
• Resolved: 23/Apr/23 22:17

Description

An IllegalStateException is thrown when calling ApplicationStateManagerImpl.getIfExists() on an invalid session. I would expect the method to catch the exception and return null in this case.

Stack trace (top only):

- org.eclipse.jetty.server.session.AbstractSession.checkValid(AbstractSession.java:106)
  - org.eclipse.jetty.server.session.AbstractSession.getAttribute(AbstractSession.java:459)
  - org.apache.tapestry5.internal.services.SessionImpl.getAttribute(SessionImpl.java:52)
  - org.apache.tapestry5.internal.services.SessionApplicationStatePersistenceStrategy.exists(SessionApplicationStatePersistenceStrategy.java:80)
  - $ApplicationStatePersistenceStrategy_b43cfdb8299.exists(Unknown Source)
  - org.apache.tapestry5.internal.services.ApplicationStateManagerImpl$ApplicationStateAdapter.exists(ApplicationStateManagerImpl.java:60)
  - org.apache.tapestry5.internal.services.ApplicationStateManagerImpl.getIfExists(ApplicationStateManagerImpl.java:140)