[TAP5-2469] RegistryImpl#loggerForBuiltinService : "Class.toString" used as logger name

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 5.4
• Fix Version/s: 5.4
• Component/s: tapestry-ioc
• Labels: easyfix logging patch
• Assignee: Unassigned
• Reporter: Nicolas Bouillon
• Created: 19/Mar/15 14:30
• Updated: 24/Mar/15 15:13
• Resolved: 24/Mar/15 13:44

Description

Starting my application i've got something like that in the log files.

15:21:27.422 [main] DEBUG class org.apache.tapestry5.ioc.modules.TapestryIOCModule.ServiceConfigurationListener - Service ServiceConfigurationListenerHub ordered configuration: []
15:21:27.726 [main] DEBUG class org.apache.tapestry5.ioc.modules.TapestryIOCModule.ServiceConfigurationListener - Service MasterObjectProvider ordered configuration: [org.apache.tapestry5.ioc.internal.services.ValueObjectProvider@29431f61, org.apache.tapestry5.ioc.internal.services.SymbolObjectProvider@f98cff, org.apache.tapestry5.ioc.internal.services.AutobuildObjectProvider@59c38af5, <Proxy for AssetObjectProvider(org.apache.tapestry5.ioc.ObjectProvider)>, org.apache.tapestry5.internal.services.ServiceAnnotationObjectProvider@6244afc4, org.apache.tapestry5.internal.services.ApplicationMessageCatalogObjectProvider@534d0cfa, org.apache.tapestry5.ioc.modules.TapestryIOCModule$2@1f1ffc18, org.apache.tapestry5.ioc.internal.RegistryImpl$7@5a4e492c]
15:21:27.810 [main] DEBUG class org.apache.tapestry5.ioc.modules.TapestryIOCModule.ServiceConfigurationListener - Service SymbolSource ordered configuration: [org.apache.tapestry5.ioc.internal.services.SystemPropertiesSymbolProvider@5bf1b528, org.apache.tapestry5.internal.SingleKeySymbolProvider@2c92f094, org.apache.tapestry5.internal.SingleKeySymbolProvider@1c3b221f, org.apache.tapestry5.ioc.internal.services.SystemEnvSymbolProvider@750c23a3, org.apache.tapestry5.internal.util.DelegatingSymbolProvider@238280df, <Proxy for ApplicationDefaults(org.apache.tapestry5.ioc.services.SymbolProvider)>, <Proxy for FactoryDefaults(org.apache.tapestry5.ioc.services.SymbolProvider)>]
15:21:27.964 [main] DEBUG class org.apache.tapestry5.ioc.modules.TapestryIOCModule.ServiceConfigurationListener - Service ServiceLifecycleSource mapped configuration: {perthread=org.apache.tapestry5.ioc.internal.services.PerThreadServiceLifecycle@7fad28ac}
15:21:28.000 [main] DEBUG class org.apache.tapestry5.ioc.modules.TapestryIOCModule.ServiceConfigurationListener - Service TypeCoercer unordered configuration: [Object --> String, Object --> Boolean, String --> Double, String --> java.math.BigDecimal, java.math.BigDecimal --> Double, String --> java.math.BigInteger, String --> Long, Long --> Byte, Long --> Short, Long --> Integer, Number --> Long, Double --> Float, Long --> Double, String --> Boolean, Number --> Boolean, null --> Boolean, java.util.Collection --> Boolean, Object --> java.util.List, Object--> java.util.List, Object--> Boolean, Float --> Double, byte--> java.util.List, short--> java.util.List, int--> java.util.List, long--> java.util.List, float--> java.util.List, double--> java.util.List, char--> java.util.List, boolean--> java.util.List, String --> java.io.File, String --> org.apache.tapestry5.ioc.util.TimeInterval, org.apache.tapestry5.ioc.util.TimeInterval --> Long, Object --> Object[], java.util.Collection --> Object[], org.apache.tapestry5.func.Flow --> java.util.List, org.apache.tapestry5.func.Flow --> Boolean, String --> org.apache.tapestry5.json.JSONObject, String --> org.apache.tapestry5.json.JSONArray, String --> com.gax.ib.user.User, com.gax.ib.user.User --> String, java.util.Date --> String, String --> java.util.Date, String --> com.gax.ib.audit.AuditTraceType, com.gax.ib.audit.AuditTraceType --> String, String --> com.gax.ib.engine.cron.CronTask, com.gax.ib.engine.cron.CronTask --> String, org.apache.tapestry5.ComponentResources --> org.apache.tapestry5.PropertyOverrides, String --> org.apache.tapestry5.SelectModel, java.util.Map --> org.apache.tapestry5.SelectModel, java.util.Collection --> org.apache.tapestry5.grid.GridDataSource, null --> org.apache.tapestry5.grid.GridDataSource, java.util.List --> org.apache.tapestry5.SelectModel, String --> java.util.regex.Pattern, org.apache.tapestry5.runtime.ComponentResourcesAware --> org.apache.tapestry5.ComponentResources, String --> org.apache.tapestry5.Renderable, org.apache.tapestry5.Renderable --> org.apache.tapestry5.Block, String --> java.text.DateFormat, String --> org.apache.tapestry5.ioc.Resource, org.apache.tapestry5.Renderable --> org.apache.tapestry5.runtime.RenderCommand, java.util.Date --> java.util.Calendar, org.apache.tapestry5.ioc.Resource --> org.apache.tapestry5.services.dynamic.DynamicTemplate, org.apache.tapestry5.Asset --> org.apache.tapestry5.ioc.Resource, org.apache.tapestry5.ValueEncoder --> org.apache.tapestry5.services.ValueEncoderFactory]
15:21:28.019 [main] DEBUG class org.apache.tapestry5.ioc.modules.TapestryIOCModule.ServiceConfigurationListener - Service ServiceOverride mapped configuration: {}
15:21:28.130 [main] DEBUG class org.apache.tapestry5.ioc.modules.TapestryIOCModule.ServiceConfigurationListener - Service ServletApplicationInitializer ordered configuration: []
15:21:28.173 [main] DEBUG class org.apache.tapestry5.ioc.modules.TapestryIOCModule.ServiceConfigurationListener - Service ApplicationInitializer ordered configuration: [org.apache.tapestry5.modules.TapestryModule$36@2d5d001f]
15:21:28.203 [main] DEBUG class org.apache.tapestry5.ioc.modules.TapestryIOCModule.ServiceConfigurationListener - Service ApplicationDefaults mapped configuration: {tapestry.file-check-interval=1 s, tapestry.supported-locales=en,fr,de, tapestry.production-mode=true, tapestry.hmac-passphrase=94a4217e-3c69-4d5e-bb6b-a4e4fad8164e, tapestry.javascript-infrastructure-provider=jquery}
15:21:28.235 [main] DEBUG class org.apache.tapestry5.ioc.modules.TapestryIOCModule.ServiceConfigurationListener - Service FactoryDefaults mapped configuration: {tapestry.include-core-stack=true, tapestry.components.grid_empty_block=block:empty, tapestry.thread-pool-enabled=true, tapestry.persistence-strategy=session, upload.repository-threshold=10240, tapestry.page-preload-mode=PRODUCTION, tapestry.datepicker=${tapestry.asset.root}/datepicker_106, tapestry.application-version=0.0.1, tapestry.components.zone_update_method=highlight, upload.repository-location=/tmp, tapestry.file-check-update-timeout=50 ms, tapestry.file-check-interval=1 s, tapestry.omit-expiration-cache-control-header=max-age=60,must-revalidate, tapestry.supported-locales=en,it,es,zh_CN,pt_PT,de,ru,hr,fi_FI,sv_SE,fr,da,pt_BR,ja,el,bg,no_NB,sr_RS,mk_MK, tapestry.components.gridcolumns_sortable_asset=sortable.png, tapestry.components.gridcolumns_ascending_asset=sort-asc.png, tapestry.start-page-name=start, tapestry.form-group-wrapper-css-class=form-group, tapestry.restrictive-environment=false, tapestry.version=5.4-beta-26, tapestry.thread-pool.max-pool-size=20, tapestry.asset.root=classpath:META-INF/assets/tapestry5, tapestry.secure-page=false, tapestry.form-client-logic-enabled=true, tapestry.charset=UTF-8, tapestry.default-cookie-max-age=7 d, tapestry.min-gzip-size=100, tapestry.thread-pool.queue-size=100, tapestry.exception-report-page=ExceptionReport, tapestry.components.forminjector_insert_position=above, tapestry.exception-reports-dir=build/exceptions, tapestry.omit-generator-meta=false, tapestry.session-locking-enabled=true, upload.filesize-max=-1, tapestry.scriptaculous=${tapestry.asset.root}/scriptaculous_1_9_0, tapestry.component-render-tracing-enabled=false, tapestry.compress-whitespace=true, tapestry.production-mode=true, tapestry.components.validate_with_model=AUTO, tapestry.hostport-secure=0, tapestry.unknwon-activation-context-check=false, tapestry.components.grid_table_css_class=table table-hover table-bordered table-striped, tapestry.form-group-form-field-wrapper-element-name=, tapestry.response-content-type=text/html, tapestry.combine-scripts=${tapestry.production-mode}, tapestry.app-catalog=context:WEB-INF/${tapestry.app-name}.properties, tapestry.enable-pageloading-mask=true, tapestry.module-path-prefix=modules, tapestry.application-folder=, tapestry.hmac-passphrase=, tapestry.javascript-infrastructure-provider=prototype, tapestry.enable-html5-support=false, tapestry.form-group-form-field-wrapper-element-css-class=, tapestry.compact-json=${tapestry.production-mode}, tapestry.form-group-label-css-class=control-label, tapestry.gzip-compression-enabled=true, tapestry.asset-url-fully-qualified=false, tapestry.reserved-form-control-names=reset,submit,select,id,method,action,onsubmit,cancel, tapestry.components.grid_rows_per_page=25, upload.requestsize-max=-1, tapestry.clustered-sessions=true, tapestry.form-field-css-class=form-control, tapestry.asset-path-prefix=assets, tapestry.components.grid_pager_position=top, tapestry.strict-css-url-rewriting=false, tapestry.bootstrap-root=${tapestry.asset.root}/bootstrap, tapestry.components.zone_show_method=show, tapestry.context-path=, tapestry.default-stylesheet=, tapestry.thread-pool.core-pool-size=3, tapestry.components.gridcolumns_descending_asset=sort-desc.png, tapestry.encode-locale-into-path=true, tapestry.components.gridpager_page_range=5, tapestry.secure-enabled=${tapestry.production-mode}, tapestry.hostname=, tapestry.hostport=0, tapestry.lenient-date-format=false, tapestry.thread-pool.keep-alive=1 m, tapestry.components.palette_rows_size=10, tapestry.white-list-only-page=false, tapestry.enable-minification=${tapestry.production-mode}, tapestry.components.forminjector_show_function=highlight}

The problem is that I've set "org.apache" as INFO level, and the rest in DEBUG level, but I still get DEBUG messages from tapestry.

The problem there is that the logger name is "class org.apache.tapestry5.ioc.modules.TapestryIOCModule.ServiceConfigurationListener".

There is an error in the code org.apache.tapestry5.ioc.internal.RegistryImpl#loggerForBuiltinService (org/apache/tapestry5/ioc/internal/RegistryImpl.java:379)

    private Logger loggerForBuiltinService(String serviceId)
    {
        return loggerSource.getLogger(TapestryIOCModule.class + "." + serviceId);
    }

It should be :

    private Logger loggerForBuiltinService(String serviceId)
    {
        return loggerSource.getLogger(TapestryIOCModule.class.getName() + "." + serviceId);
    }

(the "getName()" is missing)