[TAP5-2335] Decrease number of operations with HashMap #2

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 5.4
• Assignee: Howard Lewis Ship
• Reporter: Michael Mikhulya
• Created: 19/May/14 16:41
• Updated: 02/Aug/14 04:21
• Resolved: 01/Aug/14 19:52

Description

During profiling of tapestry framework I found that HashMap is actively used in following code:

NamedSet.java

public void eachValue(Worker<T> worker)
    {
        F.flow(getValues()).each(worker);
    }

Here HashSet (which internally uses HashMap) is created inside getValues() only to iterate over it.
I changed code to use ArrayList instead of HashSet.

With following patch time per request decreased on 3.5 ms (7.4% of overall time). Measurements were done with apache benchmark on a real application after warm up phase.