[TAP5-2267] Contributing ExceptionHandlerAssistant instances to RequestExceptionHandler is broken

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 5.4
• Fix Version/s: 5.4
• Component/s: tapestry-core
• Assignee: Kalle Korhonen
• Reporter: Dragan Sahpaski
• Created: 24/Dec/13 16:39
• Updated: 29/Dec/13 07:42
• Resolved: 29/Dec/13 07:42

Description

DefaultRequestExceptionHandler fails with ClassCastException when an instance of ExceptionHandlerAssistant is contributed to RequestExceptionHandler.

This had been broken accidentally in commit cb3d4c853f47cccf9193c33cfd085d6ca27c8706 when implementing contributions of assistant classes that are autobuilt.

Although DefaultRequestExceptionHandlerTest covers contributions of ExceptionHandlerAssistant instances, it didn't fail because of an oversight in the test.

The patch resolves the bug (trivially) and improves existing tests in DefaultRequestExceptionHandlerTest which now fail without patching DefaultRequestExceptionHandler.