Uploaded image for project: 'Tapestry 5'
  1. Tapestry 5
  2. TAP5-2267

Contributing ExceptionHandlerAssistant instances to RequestExceptionHandler is broken

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 5.4
    • Fix Version/s: 5.4
    • Component/s: tapestry-core
    • Labels:
      None

      Description

      DefaultRequestExceptionHandler fails with ClassCastException when an instance of ExceptionHandlerAssistant is contributed to RequestExceptionHandler.

      This had been broken accidentally in commit cb3d4c853f47cccf9193c33cfd085d6ca27c8706 when implementing contributions of assistant classes that are autobuilt.

      Although DefaultRequestExceptionHandlerTest covers contributions of ExceptionHandlerAssistant instances, it didn't fail because of an oversight in the test.

      The patch resolves the bug (trivially) and improves existing tests in DefaultRequestExceptionHandlerTest which now fail without patching DefaultRequestExceptionHandler.

        Attachments

        1. TAP5-2267.patch
          4 kB
          Dragan Sahpaski

          Activity

            People

            • Assignee:
              kaosko Kalle Korhonen
              Reporter:
              dragan.sahpaski Dragan Sahpaski
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: