Uploaded image for project: 'Tapestry 5'
  1. Tapestry 5
  2. TAP5-2097

Use a JavaScriptStack to import the tapestry-beanvalidator.js file.

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 5.3.6
    • Fix Version/s: 5.3.7
    • Component/s: tapestry-beanvalidator
    • Labels:
      None

      Description

      tapestry-beanvalidator is using MarkupRendererFilter to include the tapestry-beanvalidator.js in every page. Which means that if you have the tapestry-beanvalidator dependency in your project you end up importing many tapestry javascript files that you may not need. Even for an empty page, if you have tapestry-beanvalidator as a dependency it will include a dozen javascript files.

      A better approach would be to have a JavaScriptStack for tapestry-beanvalidator.js and then use a worker to import the stack ONLY when there is a form present. The tapestry-jquery project has a nice example of this, FormResourcesInclusionWorker

      https://github.com/got5/tapestry5-jquery/blob/master/src/main/java/org/got5/tapestry5/jquery/services/FormResourcesInclusionWorker.java

        Attachments

        1. TAP5-2097.patch
          13 kB
          Alejandro Scandroli

          Activity

            People

            • Assignee:
              kaosko Kalle Korhonen
              Reporter:
              ascandroli Alejandro Scandroli
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: