[TAP5-2028] org.apache.tapestry5.ioc.internal.util.MessagesImpl should load messages with UTF-8 encoding

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Incomplete
• Affects Version/s: 5.3.6
• Component/s: tapestry-ioc
• Labels: bulk-close-candidate
• Assignee: Unassigned
• Reporter: Balázs Palcsó
• Created: 22/Nov/12 07:09
• Updated: 22/Aug/16 06:47
• Resolved: 22/Aug/16 06:47

Description

In my tests I'd like to verify the content of the generated HTML. Instead of duplicating and hard coding the output messages that already exist in properties file I would like to load the messages from the properties file of the page classes I am testing.
I was looking around the possibilities and I found that MessagesImpl would fit my needs. (and also asked on the users list: http://tapestry.1045711.n5.nabble.com/Unable-to-load-messages-in-UTF-8-encoding-in-test-class-in-different-class-than-messages-belong-to-tp5717808.html)

private final Messages messages = MessagesImpl.forClass(Registration.class);
would be the proper solution to load messages of my Registration page if
MessagesImpl.forClass(Class) used UTF-8 encoding instead of the default
ISO-8859-1 (latin1) when loading properties files.
In pages and components my UTF-8 encoded properties files work correctly as
documented at http://tapestry.apache.org/localization.html

Currently MessagesImpl is part of the internal package, but I think this class would be useful wider usage therefore I would suggest moving this class to a "public" package.

Issue Links

• relates to: TAPESTRY-2525 Properties files in a message catalog should be read using UTF-8 encoding, rather than default encoding