Uploaded image for project: 'Tapestry 5'
  1. Tapestry 5
  2. TAP5-2028

org.apache.tapestry5.ioc.internal.util.MessagesImpl should load messages with UTF-8 encoding

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Incomplete
    • Affects Version/s: 5.3.6
    • Fix Version/s: None
    • Component/s: tapestry-ioc

      Description

      In my tests I'd like to verify the content of the generated HTML. Instead of duplicating and hard coding the output messages that already exist in properties file I would like to load the messages from the properties file of the page classes I am testing.
      I was looking around the possibilities and I found that MessagesImpl would fit my needs. (and also asked on the users list: http://tapestry.1045711.n5.nabble.com/Unable-to-load-messages-in-UTF-8-encoding-in-test-class-in-different-class-than-messages-belong-to-tp5717808.html)

      private final Messages messages = MessagesImpl.forClass(Registration.class);
      would be the proper solution to load messages of my Registration page if
      MessagesImpl.forClass(Class) used UTF-8 encoding instead of the default
      ISO-8859-1 (latin1) when loading properties files.
      In pages and components my UTF-8 encoded properties files work correctly as
      documented at http://tapestry.apache.org/localization.html

      Currently MessagesImpl is part of the internal package, but I think this class would be useful wider usage therefore I would suggest moving this class to a "public" package.

        Attachments

        1. MessagesImplUTF8.patch
          1 kB
          Balázs Palcsó

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                balapal Balázs Palcsó
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: