Uploaded image for project: 'Tapestry 5'
  1. Tapestry 5
  2. TAP5-2012

Make multiple same name service decoration methods error message better

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.4
    • Component/s: tapestry-ioc

      Description

      If one has many decoration methods that are named exactly the same way the other decoration is silently dropped with log warn "Could not add object with duplicate id 'ServiceInterfaceName'. The duplicate object has been ignored."

      This error message could be greatly improved if it would clearly state that there are multiple decoration methods that have the same name, and additionally it would be nice to provide the list of modules that do have the problematic methods.

      It could further be improved by having the possible fix in the message, that is to use Match annotation and to match the service interface and to change the name of the method.

      It would also be nice touch to mention in the log message which method won this time as it seems that is somewhat random, and would be useful later when diagnosing problems.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                thiagohp Thiago H. de Paula Figueiredo
                Reporter:
                9902468 Ville Virtanen
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: