Tapestry 5
  1. Tapestry 5
  2. TAP5-1927

PeriodicExecutor drops exceptions without any notice.

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Invalid
    • Affects Version/s: 5.3
    • Fix Version/s: None
    • Component/s: tapestry-ioc
    • Labels:
      None

      Description

      PeriodicExecutorImpl:176-185
      try

      { runnableJob.run(); }

      finally

      { cleanupAfterExecution(); }

      That means every occuring exception is simply skipped. It would be nice if it was logged.

        Activity

        quurks created issue -
        Hide
        Howard M. Lewis Ship added a comment -

        Runnable.run() throws no checked exception.

        It is the user's code responsibility to handle/log/retry and checked or runtime exceptions. Anything Tapestry did here (with RuntimeExceptions) would be incorrect for some people, which is why it is the client's code responsibility.

        Show
        Howard M. Lewis Ship added a comment - Runnable.run() throws no checked exception. It is the user's code responsibility to handle/log/retry and checked or runtime exceptions. Anything Tapestry did here (with RuntimeExceptions) would be incorrect for some people, which is why it is the client's code responsibility.
        Howard M. Lewis Ship made changes -
        Field Original Value New Value
        Status Open [ 1 ] Closed [ 6 ]
        Assignee Howard M. Lewis Ship [ hlship ]
        Resolution Invalid [ 6 ]
        Hide
        quurks added a comment -

        I understand why the exception is caught. But a log entry would be nice. Maybe only a trace.

        Show
        quurks added a comment - I understand why the exception is caught. But a log entry would be nice. Maybe only a trace.

          People

          • Assignee:
            Howard M. Lewis Ship
            Reporter:
            quurks
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development