[TAP5-1910] JPA and JBoss 7 datasources

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Incomplete
• Affects Version/s: 5.3.2
• Component/s: tapestry-jpa
• Labels: bulk-close-candidate
• Assignee: Unassigned
• Reporter: Miguel Figueiredo
• Created: 18/Apr/12 21:29
• Updated: 22/Aug/16 06:48
• Resolved: 22/Aug/16 06:48

Description

Hello,

I am using tapestry 5.3.2 with JBoss 7, and I'm having some problems
when using a JBoss datasource with JPA.

My datasource configuration:

<datasource jta="false"
jndi-name="java:jboss/myDatasource" pool-name="mysqlDS" enabled="true"
use-java-context="true" use-ccm="true">
(...)
</datasource>

My persistence.xml configuration:

<persistence-unit name="my-pu"
transaction-type="RESOURCE_LOCAL">
<provider>org.hibernate.ejb.HibernatePersistence</provider>
<non-jta-data-source>java:jboss/myDatasource</non-jta-data-source>
(...)
</persistence-unit>

Looking at the code in the PersistenceUnitInfoImpl of tapestry-jpa
5.3.2 I found the following:

private DataSource lookupDataSource(final String name)
{
try

{ // TODO: Create InitialContext with environment properties? final Context initContext = new InitialContext(); final Context envContext = (Context) initContext.lookup("java:comp/env"); return (DataSource) envContext.lookup(name); }

catch (final NamingException e)

{ throw new RuntimeException(e); }

}

In JBoss 7 the env context should be retrieved from java:jboss, e.g.:

final Context initContext = new InitialContext();
final Context envContext = (Context)initContext.lookup("java:jboss");
return (DataSource) envContext.lookup("myDatasource");

Maybe a datasource lookup class could be configured here.

Best regards,
Miguel