Tapestry 5
  1. Tapestry 5
  2. TAP5-1906

Interaction between client-side validation and submit buttons can result in a server-side error parsing JSON array

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 5.3, 5.4
    • Fix Version/s: 5.3.3, 5.4
    • Component/s: tapestry-core
    • Labels:

      Description

      Enter invalid text into a field that has client side validation
      Hit enter (to submit the form)
      Update the field value to be valid
      Hit enter (to submit the form)
      Form is submitted with a query parameter "t:submit" set to the blank string
      This triggers an exception inside Form:

      A JSONArray text must start with '[' at character 0 of

      org.apache.tapestry5.json.JSONTokener.syntaxError(JSONTokener.java:384)
      org.apache.tapestry5.json.JSONArray.parse(JSONArray.java:126)
      org.apache.tapestry5.json.JSONArray.<init>(JSONArray.java:95)
      org.apache.tapestry5.corelib.components.Form.isFormCancelled(Form.java:590)
      org.apache.tapestry5.corelib.components.Form.advised$onAction_12856ebccc3a27e0(Form.java:511)
      org.apache.tapestry5.corelib.components.Form$Invocation_onAction_12856ebccc3a27df.proceedToAdvisedMethod(Unknown Source)
      org.apache.tapestry5.internal.plastic.AbstractMethodInvocation.proceed(AbstractMethodInvocation.java:84)
      org.apache.tapestry5.ioc.internal.services.LoggingAdvice.advise(LoggingAdvice.java:37)
      org.apache.tapestry5.internal.plastic.AbstractMethodInvocation.proceed(AbstractMethodInvocation.java:86)
      org.apache.tapestry5.corelib.components.Form.onAction(Form.java)

        Activity

        Hide
        Hudson added a comment -

        Integrated in tapestry-trunk-freestyle #703 (See https://builds.apache.org/job/tapestry-trunk-freestyle/703/)
        TAP5-1906: Interaction between client-side validation and submit buttons can result in a server-side error parsing JSON array (Revision 1326732)

        Result = FAILURE
        hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1326732
        Files :

        • /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/LinkSubmit.java
        • /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Submit.java
        Show
        Hudson added a comment - Integrated in tapestry-trunk-freestyle #703 (See https://builds.apache.org/job/tapestry-trunk-freestyle/703/ ) TAP5-1906 : Interaction between client-side validation and submit buttons can result in a server-side error parsing JSON array (Revision 1326732) Result = FAILURE hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1326732 Files : /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/LinkSubmit.java /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Submit.java
        Hide
        Hudson added a comment -

        Integrated in tapestry-5.3-freestyle #23 (See https://builds.apache.org/job/tapestry-5.3-freestyle/23/)
        TAP5-1906: Interaction between client-side validation and submit buttons can result in a server-side error parsing JSON array (Revision 1326736)
        TAP5-1906: Interaction between client-side validation and submit buttons can result in a server-side error parsing JSON array (Revision 1326715)

        Result = FAILURE
        hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1326736
        Files :

        • /tapestry/tapestry5/branches/5.3/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/LinkSubmit.java
        • /tapestry/tapestry5/branches/5.3/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Submit.java

        hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1326715
        Files :

        • /tapestry/tapestry5/branches/5.3/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Form.java
        Show
        Hudson added a comment - Integrated in tapestry-5.3-freestyle #23 (See https://builds.apache.org/job/tapestry-5.3-freestyle/23/ ) TAP5-1906 : Interaction between client-side validation and submit buttons can result in a server-side error parsing JSON array (Revision 1326736) TAP5-1906 : Interaction between client-side validation and submit buttons can result in a server-side error parsing JSON array (Revision 1326715) Result = FAILURE hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1326736 Files : /tapestry/tapestry5/branches/5.3/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/LinkSubmit.java /tapestry/tapestry5/branches/5.3/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Submit.java hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1326715 Files : /tapestry/tapestry5/branches/5.3/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Form.java
        Hide
        Hudson added a comment -

        Integrated in tapestry-trunk-freestyle #702 (See https://builds.apache.org/job/tapestry-trunk-freestyle/702/)
        TAP5-1906: Interaction between client-side validation and submit buttons can result in a server-side error parsing JSON array (Revision 1326710)

        Result = SUCCESS
        hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1326710
        Files :

        • /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Form.java
        Show
        Hudson added a comment - Integrated in tapestry-trunk-freestyle #702 (See https://builds.apache.org/job/tapestry-trunk-freestyle/702/ ) TAP5-1906 : Interaction between client-side validation and submit buttons can result in a server-side error parsing JSON array (Revision 1326710) Result = SUCCESS hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1326710 Files : /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Form.java

          People

          • Assignee:
            Howard M. Lewis Ship
            Reporter:
            Howard M. Lewis Ship
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development