[TAP5-1901] Plastic creates field access methods for some injected fields unnecessarily

• Type: Bug
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 5.3.3, 5.4
• Component/s: plastic
• Assignee: Unassigned
• Reporter: Howard Lewis Ship
• Created: 12/Apr/12 20:48
• Updated: 06/May/14 06:36

Description

While looking into another problem, noticed the following:

final reject_field_change_internalComponentResources(Lorg/apache/tapestry5/internal/InternalComponentResources;)V
NEW java/lang/IllegalStateException
DUP
LDC "Field internalComponentResources of class test.base.pages.Grandparent is read-only."
INVOKESPECIAL java/lang/IllegalStateException.<init> (Ljava/lang/String;)V
ATHROW
MAXSTACK = 0
MAXLOCALS = 0

Plastic should not be creating such methods for injected fields; those fields are not visible to (untransformed) subclasses (they don't exist until after transformation). These kinds of methods exist for incorrect user code that (in untransformed classes) illegally assigns to a field that is read-only in the transformed class.