Tapestry 5
  1. Tapestry 5
  2. TAP5-1890

PlaceholderBlock should implement RenderCommand

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 5.3.2, 5.4
    • Fix Version/s: 5.3.7, 5.4
    • Component/s: tapestry-core
    • Labels:

      Description

      If we have an empty zone like this:
      <t:zone t:id="myZone" />

      zone.getBody() fails to update the zone in an event handler with the following exception:

      org.apache.tapestry5.ioc.util.UnknownValueException
      A component event handler method returned the value <PlaceholderBlock>. Return type org.apache.tapestry5.internal.structure.ComponentPageElementImpl$PlaceholderBlock can not be handled.

      This is because ComponentPageElementImpl.PlaceholderBlock does not implement RenderCommand.

      A patch is provided with a test that fails.

      I would highly appreciate it if a commiter applies it to the 5.4. branch and to the 5.3. branch.

      Cheers,
      Dragan Sahpaski

      1. TAP-1890.patch
        3 kB
        Dragan Sahpaski

        Activity

        Hide
        Kalle Korhonen added a comment -

        Applied to 5.4 trunk. While trivial to apply to 5.3.x branch, not sure if it's critical enough. Any justifications?

        Show
        Kalle Korhonen added a comment - Applied to 5.4 trunk. While trivial to apply to 5.3.x branch, not sure if it's critical enough. Any justifications?
        Hide
        Hudson added a comment -

        Integrated in tapestry-trunk-freestyle #694 (See https://builds.apache.org/job/tapestry-trunk-freestyle/694/)
        RESOLVED - TAP5-1890: PlaceholderBlock should implement RenderCommand

        • apply Dragan Sahpaski's patch, including tests, without changes (Revision 1307062)

        Result = SUCCESS
        kaosko : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1307062
        Files :

        • /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/structure/ComponentPageElementImpl.java
        • /tapestry/tapestry5/trunk/tapestry-core/src/test/app1/nested/ZoneDemo.tml
        • /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/ZoneTests.java
        • /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/pages/nested/ZoneDemo.java
        Show
        Hudson added a comment - Integrated in tapestry-trunk-freestyle #694 (See https://builds.apache.org/job/tapestry-trunk-freestyle/694/ ) RESOLVED - TAP5-1890 : PlaceholderBlock should implement RenderCommand apply Dragan Sahpaski's patch, including tests, without changes (Revision 1307062) Result = SUCCESS kaosko : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1307062 Files : /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/structure/ComponentPageElementImpl.java /tapestry/tapestry5/trunk/tapestry-core/src/test/app1/nested/ZoneDemo.tml /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/ZoneTests.java /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/pages/nested/ZoneDemo.java
        Hide
        Dragan Sahpaski added a comment -

        No it's ok.
        I haven't heard anyone else complaining. It's just going to be annoying when I notice it again but more than one workaround are possible.

        Thanks.

        Show
        Dragan Sahpaski added a comment - No it's ok. I haven't heard anyone else complaining. It's just going to be annoying when I notice it again but more than one workaround are possible. Thanks.
        Hide
        Kalle Korhonen added a comment -

        Right, that's what I figured. Had there not been any workarounds available, I would have been more inclined to apply to 5.3 as well. Resolving.

        Show
        Kalle Korhonen added a comment - Right, that's what I figured. Had there not been any workarounds available, I would have been more inclined to apply to 5.3 as well. Resolving.

          People

          • Assignee:
            Kalle Korhonen
            Reporter:
            Dragan Sahpaski
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development