[TAP5-1890] PlaceholderBlock should implement RenderCommand

• Type: Bug
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 5.3.2, 5.4
• Fix Version/s: 5.3.7, 5.4
• Component/s: tapestry-core
• Labels: block zone
• Assignee: Kalle Korhonen
• Reporter: Dragan Sahpaski
• Created: 29/Mar/12 16:32
• Updated: 16/Apr/13 21:12
• Resolved: 29/Mar/12 21:40

Description

If we have an empty zone like this:
<t:zone t:id="myZone" />

zone.getBody() fails to update the zone in an event handler with the following exception:

org.apache.tapestry5.ioc.util.UnknownValueException
A component event handler method returned the value <PlaceholderBlock>. Return type org.apache.tapestry5.internal.structure.ComponentPageElementImpl$PlaceholderBlock can not be handled.

This is because ComponentPageElementImpl.PlaceholderBlock does not implement RenderCommand.

A patch is provided with a test that fails.

I would highly appreciate it if a commiter applies it to the 5.4. branch and to the 5.3. branch.

Cheers,
Dragan Sahpaski