[TAP5-1868] SRSCachingInterceptor returns compressed version of asset for all clients once it was compressed for some client

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 5.3.2
• Fix Version/s: 5.3.5, 5.4
• Component/s: tapestry-core
• Labels: fixed-in-5.4-js-rewrite
• Assignee: Howard Lewis Ship
• Reporter: Dmitry Gusev
• Created: 09/Mar/12 09:42
• Updated: 16/Dec/12 01:45
• Resolved: 16/Dec/12 01:30

Description

Cache lookup ignores StreamableResourceProcessing argument.

public class SRSCachingInterceptor implements StreamableResourceSource, InvalidationListener
{
...

public StreamableResource getStreamableResource(Resource baseResource, StreamableResourceProcessing processing, ResourceDependencies dependencies)
throws IOException
{
if (processing == StreamableResourceProcessing.FOR_AGGREGATION)

{ return delegate.getStreamableResource(baseResource, processing, dependencies); }

StreamableResource result = TapestryInternalUtils.getAndDeref(cache, baseResource);

if (result == null)
{
result = delegate.getStreamableResource(baseResource, processing, dependencies);

if (isCacheable(result))

{ dependencies.addDependency(baseResource); cache.put(baseResource, new SoftReference<StreamableResource>(result)); }

}

return result;
}