Tapestry 5
  1. Tapestry 5
  2. TAP5-1836

"LocalhostOnly" WhitelistAnalyzer check "0:0:0:0:0:0:0:1%0" ip address instead "0:0:0:0:0:0:0:1"

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 5.3.1
    • Fix Version/s: 5.3.3, 5.4
    • Component/s: tapestry-core
    • Labels:
      None

      Description

      "LocalhostOnly" WhitelistAnalyzer check "0:0:0:0:0:0:0:1%0" ip address but my request object return "0:0:0:0:0:0:0:1" and pages not whitelisted on localhost

        Activity

        Hide
        Hudson added a comment -

        Integrated in tapestry-trunk-freestyle #686 (See https://builds.apache.org/job/tapestry-trunk-freestyle/686/)
        TAP5-1836: Add 0:0:0:0:0:0:0:1 as another recognized value for remoteHost meaning local (Revision 1293000)

        Result = SUCCESS
        hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1293000
        Files :

        • /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/security/LocalhostOnly.java
        Show
        Hudson added a comment - Integrated in tapestry-trunk-freestyle #686 (See https://builds.apache.org/job/tapestry-trunk-freestyle/686/ ) TAP5-1836 : Add 0:0:0:0:0:0:0:1 as another recognized value for remoteHost meaning local (Revision 1293000) Result = SUCCESS hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1293000 Files : /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/security/LocalhostOnly.java
        Hide
        Hudson added a comment -

        Integrated in tapestry-5.3-freestyle #12 (See https://builds.apache.org/job/tapestry-5.3-freestyle/12/)
        TAP5-1836: Add 0:0:0:0:0:0:0:1 as another recognized value for remoteHost meaning local (Revision 1293003)

        Result = SUCCESS
        hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1293003
        Files :

        • /tapestry/tapestry5/branches/5.3/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/security/LocalhostOnly.java
        Show
        Hudson added a comment - Integrated in tapestry-5.3-freestyle #12 (See https://builds.apache.org/job/tapestry-5.3-freestyle/12/ ) TAP5-1836 : Add 0:0:0:0:0:0:0:1 as another recognized value for remoteHost meaning local (Revision 1293003) Result = SUCCESS hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1293003 Files : /tapestry/tapestry5/branches/5.3/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/security/LocalhostOnly.java
        Hide
        Steve Eynon added a comment -

        For those using 5.3.2 this contribution to your AppModule gets round the issue:

        @Contribute(ClientWhitelist.class)
        public static void extendLocalhost(OrderedConfiguration<WhitelistAnalyzer> configuration) {
        configuration.add("LocalhostOnly", new WhitelistAnalyzer() {
        @Override // standard T5 only allows localhost & "0:0:0:0:0:0:0:1%0"
        public boolean isRequestOnWhitelist(Request request)

        { return request.getRemoteHost().equals("0:0:0:0:0:0:0:1"); }

        });
        }

        Show
        Steve Eynon added a comment - For those using 5.3.2 this contribution to your AppModule gets round the issue: @Contribute(ClientWhitelist.class) public static void extendLocalhost(OrderedConfiguration<WhitelistAnalyzer> configuration) { configuration.add("LocalhostOnly", new WhitelistAnalyzer() { @Override // standard T5 only allows localhost & "0:0:0:0:0:0:0:1%0" public boolean isRequestOnWhitelist(Request request) { return request.getRemoteHost().equals("0:0:0:0:0:0:0:1"); } }); }

          People

          • Assignee:
            Howard M. Lewis Ship
            Reporter:
            Mihail Slobodyanuk
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development