[TAP5-1802] Component tracing check should check if there is a request

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 5.3
• Fix Version/s: 5.4
• Component/s: tapestry-core
• Assignee: Howard Lewis Ship
• Reporter: Denis Stepanov
• Created: 22/Dec/11 14:41
• Updated: 04/Mar/14 02:08
• Resolved: 04/Mar/14 02:08

Description

In ComponentPageElementImpl there is a check if request has a parameter to enable component tracing:

// should be okay since it's a shadow service object - NOT
private final Request request;

return !productionMode && (componentTracingEnabled || "true".equals(request.getParameter("t:component-trace")));

in a case when PageDocumentGenerator is used there is no request and shadow builder will throw an exception.

Solution would be to use RequestGlobals and check if there is a request.