Uploaded image for project: 'Tapestry 5'
  1. Tapestry 5
  2. TAP5-1802

Component tracing check should check if there is a request

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 5.3
    • Fix Version/s: 5.4
    • Component/s: tapestry-core
    • Labels:
      None

      Description

      In ComponentPageElementImpl there is a check if request has a parameter to enable component tracing:

      // should be okay since it's a shadow service object - NOT
      private final Request request;

      return !productionMode && (componentTracingEnabled || "true".equals(request.getParameter("t:component-trace")));

      in a case when PageDocumentGenerator is used there is no request and shadow builder will throw an exception.

      Solution would be to use RequestGlobals and check if there is a request.

        Attachments

          Activity

            People

            • Assignee:
              hlship Howard M. Lewis Ship
              Reporter:
              denis.stepanov Denis Stepanov
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: