[TAP5-1706] JS syntax error in Tapestry.ajaxRequest() when Ajax fails

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 5.3, 5.2.6
• Fix Version/s: 5.3
• Component/s: tapestry-core
• Assignee: Howard Lewis Ship
• Reporter: Steve Eynon
• Created: 19/Oct/11 15:43
• Updated: 19/Oct/11 17:38
• Resolved: 19/Oct/11 17:04

Description

In tapestry.js the JS Tapestry.ajaxRequest() method accesses the finalOptions variable incorrectly.

It is a prototype $H Hash, not an array, and so must be accessed as such:

finalOptions.toObject().onFailure.call(this, response);

and not

finalOptions.onFailure.call(this, response);

Attached is a patch for this...

...although looking at the docs - http://api.prototypejs.org/language/dollar-H/ - a more optimal approach may be

finalOptions.get('onFailure').call(this, response);