Tapestry 5
  1. Tapestry 5
  2. TAP5-1633

Hardcoded value for "Dismiss All" in AlertManager

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 5.3
    • Fix Version/s: 5.3
    • Component/s: None
    • Labels:
      None

      Description

      The "Dissmiss all" label that is shown just under the active alerts, is hardcoded in t5-alerts.js, and I see no easy way of overriding it, except with JavaScript, which is just ugly.

      Please provide a way for us to override this message.

        Activity

        Hide
        Hudson added a comment -

        Integrated in tapestry-trunk-freestyle #524 (See https://builds.apache.org/job/tapestry-trunk-freestyle/524/)
        TAP5-1652: template expansion no longer trims whitespace off the right side of the expansion
        TAP5-1633: Hardcoded value for "Dismiss All" in AlertManager

        robertdzeigler : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1171593
        Files :

        • /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Alerts.java
        • /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/SaxTemplateParser.java
        • /tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/corelib/components/Alerts.properties
        • /tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/t5-alerts.js
        • /tapestry/tapestry5/trunk/tapestry-core/src/test/app1/MapExpressionInExpansions.tml
        • /tapestry/tapestry5/trunk/tapestry-core/src/test/groovy/org/apache/tapestry5/integration/app1/AlertsTests.groovy
        • /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/internal/services/TemplateParserImplTest.java
        • /tapestry/tapestry5/trunk/tapestry-core/src/test/resources/org/apache/tapestry5/integration/app1/pages/AlertsDemo.tml
        • /tapestry/tapestry5/trunk/tapestry-core/src/test/resources/org/apache/tapestry5/internal/services/expansions_with_whitespace.tml
        Show
        Hudson added a comment - Integrated in tapestry-trunk-freestyle #524 (See https://builds.apache.org/job/tapestry-trunk-freestyle/524/ ) TAP5-1652 : template expansion no longer trims whitespace off the right side of the expansion TAP5-1633 : Hardcoded value for "Dismiss All" in AlertManager robertdzeigler : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1171593 Files : /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Alerts.java /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/SaxTemplateParser.java /tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/corelib/components/Alerts.properties /tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/t5-alerts.js /tapestry/tapestry5/trunk/tapestry-core/src/test/app1/MapExpressionInExpansions.tml /tapestry/tapestry5/trunk/tapestry-core/src/test/groovy/org/apache/tapestry5/integration/app1/AlertsTests.groovy /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/internal/services/TemplateParserImplTest.java /tapestry/tapestry5/trunk/tapestry-core/src/test/resources/org/apache/tapestry5/integration/app1/pages/AlertsDemo.tml /tapestry/tapestry5/trunk/tapestry-core/src/test/resources/org/apache/tapestry5/internal/services/expansions_with_whitespace.tml
        Hide
        Robert Zeigler added a comment -

        Implemented as a parameter that uses the message catalog to provide a default (key: dismiss-label). So you can override it for each component usage, or provide an alternate value in your application's message catalog to override the text application-wide.

        Show
        Robert Zeigler added a comment - Implemented as a parameter that uses the message catalog to provide a default (key: dismiss-label). So you can override it for each component usage, or provide an alternate value in your application's message catalog to override the text application-wide.

          People

          • Assignee:
            Robert Zeigler
            Reporter:
            Dusko Jovanovski
          • Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development