Tapestry 5
  1. Tapestry 5
  2. TAP5-1591

tapestry-ioc should not depend on tapestry-json

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.3
    • Component/s: tapestry-ioc
    • Labels:
      None

      Description

      Tapestry-IoC should not depend on Tapestry-JSON
      Bindings from String to JSONArray and JSONObject are twice provided (also by tapestry-core)

        Activity

        Tom van Dijk created issue -
        Tom van Dijk made changes -
        Field Original Value New Value
        Attachment 0001-TAP5-1591-IoC-should-not-depend-on-JSON.patch [ 12487903 ]
        Howard M. Lewis Ship made changes -
        Summary IoC should not depend on JSON tapestry-ioc should not depend on tapestry-json
        Howard M. Lewis Ship made changes -
        Assignee Howard M. Lewis Ship [ hlship ]
        Howard M. Lewis Ship made changes -
        Status Open [ 1 ] Closed [ 6 ]
        Fix Version/s 5.3 [ 12316024 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in tapestry-trunk-freestyle #444 (See https://builds.apache.org/job/tapestry-trunk-freestyle/444/)
        TAP5-1591: tapestry-ioc should not depend on tapestry-json

        hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1152665
        Files :

        • /tapestry/tapestry5/trunk/tapestry-json/build.gradle
        • /tapestry/tapestry5/trunk/tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/internal/services/TypeCoercerImplTest.java
        • /tapestry/tapestry5/trunk/tapestry-core/src/test/groovy/org/apache/tapestry5/root/StringToJSONTests.groovy
        • /tapestry/tapestry5/trunk/tapestry-json/src/main/java/org/apache/tapestry5/json/services/JSONModule.java
        • /tapestry/tapestry5/trunk/tapestry-json/src/main/java/org/apache/tapestry5/json/services
        • /tapestry/tapestry5/trunk/tapestry-ioc/build.gradle
        • /tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/services/TapestryIOCModule.java
        • /tapestry/tapestry5/trunk/tapestry-json/src/main/java/org/apache/tapestry5/internal/json/StringToJSONObject.java
        • /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/json/StringToJSONObject.java
        • /tapestry/tapestry5/trunk/tapestry-json/src/main/java/org/apache/tapestry5/internal/json
        • /tapestry/tapestry5/trunk/tapestry-json/src/main/java/org/apache/tapestry5/internal
        • /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/json/StringToJSONArray.java
        • /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TapestryModule.java
        • /tapestry/tapestry5/trunk/tapestry-json/src/main/java/org/apache/tapestry5/internal/json/StringToJSONArray.java
        Show
        Hudson added a comment - Integrated in tapestry-trunk-freestyle #444 (See https://builds.apache.org/job/tapestry-trunk-freestyle/444/ ) TAP5-1591 : tapestry-ioc should not depend on tapestry-json hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1152665 Files : /tapestry/tapestry5/trunk/tapestry-json/build.gradle /tapestry/tapestry5/trunk/tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/internal/services/TypeCoercerImplTest.java /tapestry/tapestry5/trunk/tapestry-core/src/test/groovy/org/apache/tapestry5/root/StringToJSONTests.groovy /tapestry/tapestry5/trunk/tapestry-json/src/main/java/org/apache/tapestry5/json/services/JSONModule.java /tapestry/tapestry5/trunk/tapestry-json/src/main/java/org/apache/tapestry5/json/services /tapestry/tapestry5/trunk/tapestry-ioc/build.gradle /tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/services/TapestryIOCModule.java /tapestry/tapestry5/trunk/tapestry-json/src/main/java/org/apache/tapestry5/internal/json/StringToJSONObject.java /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/json/StringToJSONObject.java /tapestry/tapestry5/trunk/tapestry-json/src/main/java/org/apache/tapestry5/internal/json /tapestry/tapestry5/trunk/tapestry-json/src/main/java/org/apache/tapestry5/internal /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/json/StringToJSONArray.java /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TapestryModule.java /tapestry/tapestry5/trunk/tapestry-json/src/main/java/org/apache/tapestry5/internal/json/StringToJSONArray.java
        Hide
        Hudson added a comment -

        Integrated in tapestry-trunk-freestyle #445 (See https://builds.apache.org/job/tapestry-trunk-freestyle/445/)
        TAP5-1591: Add additional tests for tapestry-json

        hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1153704
        Files :

        • /tapestry/tapestry5/trunk/tapestry-json/src/test/groovy/org/apache
        • /tapestry/tapestry5/trunk/tapestry-json/src/test/groovy
        • /tapestry/tapestry5/trunk/tapestry-json/src/test/groovy/org/apache/tapestry
        • /tapestry/tapestry5/trunk/tapestry-json/src/test/groovy/org/apache/tapestry/json/CoercionTests.groovy
        • /tapestry/tapestry5/trunk/tapestry-json/src/test/groovy/org
        • /tapestry/tapestry5/trunk/tapestry-json/src/test/groovy/org/apache/tapestry/json
        Show
        Hudson added a comment - Integrated in tapestry-trunk-freestyle #445 (See https://builds.apache.org/job/tapestry-trunk-freestyle/445/ ) TAP5-1591 : Add additional tests for tapestry-json hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1153704 Files : /tapestry/tapestry5/trunk/tapestry-json/src/test/groovy/org/apache /tapestry/tapestry5/trunk/tapestry-json/src/test/groovy /tapestry/tapestry5/trunk/tapestry-json/src/test/groovy/org/apache/tapestry /tapestry/tapestry5/trunk/tapestry-json/src/test/groovy/org/apache/tapestry/json/CoercionTests.groovy /tapestry/tapestry5/trunk/tapestry-json/src/test/groovy/org /tapestry/tapestry5/trunk/tapestry-json/src/test/groovy/org/apache/tapestry/json

          People

          • Assignee:
            Howard M. Lewis Ship
            Reporter:
            Tom van Dijk
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development