Tapestry 5
  1. Tapestry 5
  2. TAP5-1580

A Form with an event listener for "canceled" event can cause an NPE popping off a BeanEditContext from the Environment that wasn't pushed

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 5.3
    • Fix Version/s: 5.3
    • Component/s: tapestry-core
    • Labels:
      None

      Description

      Either need to push the BeanEditContext into the Environment earlier, or take extra care not to pop it off unless it was pushed. Probably do the first.

        Activity

        Hide
        Hudson added a comment -

        Integrated in tapestry-trunk-freestyle #423 (See https://builds.apache.org/job/tapestry-trunk-freestyle/423/)
        TAP5-1580: A Form with an event listener for "canceled" event can cause an NPE popping off a BeanEditContext from the Environment that wasn't pushed

        hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1148599
        Files :

        • /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Form.java
        Show
        Hudson added a comment - Integrated in tapestry-trunk-freestyle #423 (See https://builds.apache.org/job/tapestry-trunk-freestyle/423/ ) TAP5-1580 : A Form with an event listener for "canceled" event can cause an NPE popping off a BeanEditContext from the Environment that wasn't pushed hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1148599 Files : /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Form.java
        Hide
        Howard M. Lewis Ship added a comment -

        Too two tries to fix it!

        Show
        Howard M. Lewis Ship added a comment - Too two tries to fix it!
        Hide
        Hudson added a comment -

        Integrated in tapestry-trunk-freestyle #424 (See https://builds.apache.org/job/tapestry-trunk-freestyle/424/)
        TAP5-1580: A Form with an event listener for "canceled" event can cause an NPE popping off a BeanEditContext from the Environment that wasn't pushed
        Roll version number back to alpha-5, due to problem with TAP5-1580 fix

        hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1148606
        Files :

        • /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Form.java

        hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1148605
        Files :

        • /tapestry/tapestry5/trunk/build.gradle
        Show
        Hudson added a comment - Integrated in tapestry-trunk-freestyle #424 (See https://builds.apache.org/job/tapestry-trunk-freestyle/424/ ) TAP5-1580 : A Form with an event listener for "canceled" event can cause an NPE popping off a BeanEditContext from the Environment that wasn't pushed Roll version number back to alpha-5, due to problem with TAP5-1580 fix hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1148606 Files : /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/Form.java hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1148605 Files : /tapestry/tapestry5/trunk/build.gradle
        Hide
        Hudson added a comment -

        Integrated in tapestry-trunk-freestyle #435 (See https://builds.apache.org/job/tapestry-trunk-freestyle/435/)
        TAP5-1580: Provide more logging information about pruned pages
        TAP5-1580: Mark additional constants as deprecated

        hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1150818
        Files :

        • /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/PageSourceImpl.java
        • /tapestry/tapestry5/trunk/tapestry-core/src/test/groovy/org/apache/tapestry5/integration/app5/SkinningTests.groovy
        • /tapestry/tapestry5/trunk/tapestry-core/src/test/groovy/org/apache/tapestry5/internal/pageload/ComponentResourceSelectorTests.groovy
        • /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/pageload/ComponentResourceSelector.java

        hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1150813
        Files :

        • /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TransformConstants.java
        Show
        Hudson added a comment - Integrated in tapestry-trunk-freestyle #435 (See https://builds.apache.org/job/tapestry-trunk-freestyle/435/ ) TAP5-1580 : Provide more logging information about pruned pages TAP5-1580 : Mark additional constants as deprecated hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1150818 Files : /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/PageSourceImpl.java /tapestry/tapestry5/trunk/tapestry-core/src/test/groovy/org/apache/tapestry5/integration/app5/SkinningTests.groovy /tapestry/tapestry5/trunk/tapestry-core/src/test/groovy/org/apache/tapestry5/internal/pageload/ComponentResourceSelectorTests.groovy /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/pageload/ComponentResourceSelector.java hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1150813 Files : /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/TransformConstants.java

          People

          • Assignee:
            Howard M. Lewis Ship
            Reporter:
            Howard M. Lewis Ship
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development