Tapestry 5
  1. Tapestry 5
  2. TAP5-1551

FormFragment change visibility/hide and remove event listeners should call event.stop() to prevent container fragments from also being hidden

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 5.3, 5.2.5
    • Fix Version/s: 5.3, 5.2.6
    • Component/s: None
    • Labels:
      None

      Description

      In 5.2.x, FormFragment switched from using direct calls to a "setVisible" function on the fragment to using an event-based approach where the fragment element listens for the Tapestry.CHANGE_VISIBILITY_EVENT or the Tapestry.HIDE_AND_REMOVE_EVENT. The current implementation, however, does not allow for nesting form fragments because the event listeners do not call event.stop(), so the event continues to propagate, so hiding an "inner" form fragment hides the outer form fragment, as well.

        Activity

        Robert Zeigler created issue -
        Robert Zeigler made changes -
        Field Original Value New Value
        Assignee Robert Zeigler [ ongakugainochi ]
        Robert Zeigler made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Robert Zeigler made changes -
        Status In Progress [ 3 ] Resolved [ 5 ]
        Fix Version/s 5.3.1 [ 12316673 ]
        Fix Version/s 5.2.6 [ 12316674 ]
        Resolution Fixed [ 1 ]
        Robert Zeigler made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Hide
        Hudson added a comment -

        Integrated in tapestry-trunk-freestyle #378 (See https://builds.apache.org/job/tapestry-trunk-freestyle/378/)

        Show
        Hudson added a comment - Integrated in tapestry-trunk-freestyle #378 (See https://builds.apache.org/job/tapestry-trunk-freestyle/378/ )
        Howard M. Lewis Ship made changes -
        Affects Version/s 5.3 [ 12316024 ]
        Affects Version/s 5.3.0 [ 12316023 ]
        Howard M. Lewis Ship made changes -
        Fix Version/s 5.3 [ 12316024 ]
        Fix Version/s 5.3.1 [ 12316673 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open In Progress In Progress
        4d 46m 1 Robert Zeigler 22/Jun/11 07:49
        In Progress In Progress Resolved Resolved
        2h 7m 1 Robert Zeigler 22/Jun/11 09:56
        Resolved Resolved Closed Closed
        16s 1 Robert Zeigler 22/Jun/11 09:57

          People

          • Assignee:
            Robert Zeigler
            Reporter:
            Robert Zeigler
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development