[TAP5-1538] Optimize client-side URL rebuilding in IE 7

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 5.3, 5.2.5
• Fix Version/s: 5.3, 5.2.6
• Component/s: tapestry-core
• Labels: javascript, performance
• Assignee: Howard Lewis Ship
• Reporter: Pedro Ayala
• Created: 02/Jun/11 11:10
• Updated: 04/Jul/11 20:21
• Resolved: 21/Jun/11 21:40

Description

While loading the tapestry javascript, we execute the "contains" function for every script and css files in the page. The function tries to find if we already have one asset in the list of script.

Firefox and Chrome already contains the complete URL, but IE needs to call rebuildURL to get it. This results in calling the function hundred of times so any little optimization of it saves some javascript loading time.

The most expensive operation is the one for retrieving the window.location url and adding it to the path parameter. In order to improve it, we can save the basic build url in a local variable and just add the path to it.

1. 1. 1. Eclipse Workspace Patch 1.0
         #P tapestry-core
         Index: src/main/resources/org/apache/tapestry5/tapestry.js
         ===================================================================
      • src/main/resources/org/apache/tapestry5/tapestry.js (revision 1129681)
        +++ src/main/resources/org/apache/tapestry5/tapestry.js (working copy)
        @@ -522,8 +522,12 @@
        return path;
        }

• var l = window.location;
• return l.protocol + "//" + l.host + path;
  + if (!Tapestry.buildUrl) { + var l = window.location; + Tapestry.buildUrl = l.protocol + "//" + l.host; + }

  +
  + return Tapestry.buildUrl + path;
  },

stripToLastSlash : function(URL) {