Uploaded image for project: 'Tapestry 5'
  1. Tapestry 5
  2. TAP5-1483

AssetPathConstructorImpl should use BaseURLSource

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 5.2
    • Fix Version/s: 5.3
    • Component/s: tapestry-core
    • Labels:
      None

      Description

      Asset paths should be constructed using the BaseURLSource rather than just the request context path to match the behavior for pages, etc. Currently, to get absolute URL's including domain portion for assets, you need to override the AssetPathConstructor.

      Apart from contributing the BaseURLSource, it is a small change from:
      StringBuilder builder = new StringBuilder(request.getContextPath());
      to
      StringBuilder builder = new StringBuilder(baseURLSource.getBaseURL(request.isSecure()));
      builder.append(request.getContextPath());

        Attachments

        1. patch.txt
          2 kB
          Jonathan Barker

          Activity

            People

            • Assignee:
              mlusetti Massimo Lusetti
              Reporter:
              jabarker Jonathan Barker
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: