[TAP5-1425] AssetSource.getUnlocalizedAsset() should throw an exception if asset is found but does not actually exist

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 5.3, 5.2
• Fix Version/s: 5.3
• Component/s: tapestry-core
• Assignee: Massimo Lusetti
• Reporter: Howard Lewis Ship
• Created: 25/Jan/11 19:28
• Updated: 25/Jul/13 19:27
• Resolved: 25/Jul/13 19:27

Description

From the JavaDoc:

/**

• Find an asset but does not attempt to localize it. If the path has no prefix, it is assumed to
• be on the classpath.
• @since 5.2.0
• @throws RuntimeException
• if the asset can not be found
  */
  Asset getUnlocalizedAsset(String path);

I discoverred that I can pass an invalid path name and it works.

private Asset getLocalizedAssetFromResource(Resource unlocalized, Locale locale)

{ Resource localized = locale == null ? unlocalized : unlocalized.forLocale(locale); if (localized == null) throw new RuntimeException(ServicesMessages.assetDoesNotExist(unlocalized)); return getAssetForResource(localized); }

That should be:

if (localized == null || ! localized.exists())