Tapestry 5
  1. Tapestry 5
  2. TAP5-1350

TapestryFilter should allow sub-classes to specify additional module classes, not just ModuleDefs

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 5.2.5
    • Fix Version/s: 5.3
    • Component/s: tapestry-core
    • Labels:
      None

      Description

      Currently, only this method is provided:

      protected ModuleDef[] provideExtraModuleDefs(ServletContext context)

      The problem with this is that the @SubModule annotation is not supported by RegistryBuilder.add(ModuleDef) ... its supported by RegistryBuilder.add(Class...).

      An additional method:

      protected Class provideExtraModuleClasses(ServletContext context);

      would fit the bill.

        Activity

        Hide
        Hudson added a comment -

        Integrated in tapestry-trunk-freestyle #538 (See https://builds.apache.org/job/tapestry-trunk-freestyle/538/)
        TAP5-1350: TapestryFilter should allow sub-classes to specify additional module classes, not just ModuleDefs

        hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1174977
        Files :

        • /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/TapestryFilter.java
        Show
        Hudson added a comment - Integrated in tapestry-trunk-freestyle #538 (See https://builds.apache.org/job/tapestry-trunk-freestyle/538/ ) TAP5-1350 : TapestryFilter should allow sub-classes to specify additional module classes, not just ModuleDefs hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1174977 Files : /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/TapestryFilter.java
        Howard M. Lewis Ship made changes -
        Field Original Value New Value
        Status Open [ 1 ] Closed [ 6 ]
        Assignee Howard M. Lewis Ship [ hlship ]
        Fix Version/s 5.3 [ 12316024 ]
        Resolution Fixed [ 1 ]
        Howard M. Lewis Ship created issue -

          People

          • Assignee:
            Howard M. Lewis Ship
            Reporter:
            Howard M. Lewis Ship
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development