Tapestry 5
  1. Tapestry 5
  2. TAP5-1329

Tapestry allows a template to define the same extension-point id twice, which causes difficult to understand duplicate component id exceptions

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 5.2.2
    • Fix Version/s: 5.3
    • Component/s: tapestry-core
    • Labels:
      None

      Description

      Probably dates back to 5.1.

      If the parent template looks like:

      <t:extension-point id="foo"/> ... <t:extension-point id="foo"/> ...

      and the child template extends:

      <t:replace id="foo"> <t:form t:id="myForm"> ... </t:replace>

      then the exception is that myForm is a duplicate embedded component id.

      Effectively, Tapestry has "pasted" the <t:form ...> into two places of the parent template.

      Tapestry should have thrown an exception when parsing the parent template.

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Closed Closed
        354d 20h 45m 1 Howard M. Lewis Ship 17/Oct/11 21:01
        Hide
        Hudson added a comment -

        Integrated in tapestry-trunk-freestyle #578 (See https://builds.apache.org/job/tapestry-trunk-freestyle/578/)
        TAP5-1329: Tapestry allows a template to define the same extension-point id twice, which causes difficult to understand duplicate component id exceptions

        hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1185348
        Files :

        • /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/SaxTemplateParser.java
        • /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/internal/services/TemplateParserImplTest.java
        • /tapestry/tapestry5/trunk/tapestry-core/src/test/resources/org/apache/tapestry5/internal/services/dupe_extension_point_id.tml
        Show
        Hudson added a comment - Integrated in tapestry-trunk-freestyle #578 (See https://builds.apache.org/job/tapestry-trunk-freestyle/578/ ) TAP5-1329 : Tapestry allows a template to define the same extension-point id twice, which causes difficult to understand duplicate component id exceptions hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1185348 Files : /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/SaxTemplateParser.java /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/internal/services/TemplateParserImplTest.java /tapestry/tapestry5/trunk/tapestry-core/src/test/resources/org/apache/tapestry5/internal/services/dupe_extension_point_id.tml
        Howard M. Lewis Ship made changes -
        Status Open [ 1 ] Closed [ 6 ]
        Fix Version/s 5.3 [ 12316024 ]
        Resolution Fixed [ 1 ]
        Howard M. Lewis Ship made changes -
        Field Original Value New Value
        Assignee Howard M. Lewis Ship [ hlship ]
        Howard M. Lewis Ship created issue -

          People

          • Assignee:
            Howard M. Lewis Ship
            Reporter:
            Howard M. Lewis Ship
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development