Tapestry 5
  1. Tapestry 5
  2. TAP5-132

ComponentSource#getPage(String) does not handle a blank page name correctly

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 5.0.15
    • Fix Version/s: 5.0.16
    • Component/s: None
    • Labels:
      None

      Description

      Between Tapestry 5.0.14 and 5.0.15 ComponentSource#getPage(String) was changed to not allow blank page names.

      Unfortunately, Tapestry itself will sometimes provide a blank string as the logical page name. Logic that depends on ComponentSource#getPage(String) working with logical page names is therefore at risk of throwing exceptions.

      The call to Defense#notBlank needs to be removed or Tapestry will have to make sure never to supply a blank string as the logical page name.

        Activity

        Hide
        Filip S. Adamsen added a comment -

        This isn't as big a deal as I thought at first. I still believe something should be done, though.

        Show
        Filip S. Adamsen added a comment - This isn't as big a deal as I thought at first. I still believe something should be done, though.

          People

          • Assignee:
            Howard M. Lewis Ship
            Reporter:
            Filip S. Adamsen
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development