Tapestry 5
  1. Tapestry 5
  2. TAP5-132

ComponentSource#getPage(String) does not handle a blank page name correctly

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 5.0.15
    • Fix Version/s: 5.0.16
    • Component/s: None
    • Labels:
      None

      Description

      Between Tapestry 5.0.14 and 5.0.15 ComponentSource#getPage(String) was changed to not allow blank page names.

      Unfortunately, Tapestry itself will sometimes provide a blank string as the logical page name. Logic that depends on ComponentSource#getPage(String) working with logical page names is therefore at risk of throwing exceptions.

      The call to Defense#notBlank needs to be removed or Tapestry will have to make sure never to supply a blank string as the logical page name.

        Activity

        Filip S. Adamsen created issue -
        Hide
        Filip S. Adamsen added a comment -

        This isn't as big a deal as I thought at first. I still believe something should be done, though.

        Show
        Filip S. Adamsen added a comment - This isn't as big a deal as I thought at first. I still believe something should be done, though.
        Filip S. Adamsen made changes -
        Field Original Value New Value
        Priority Blocker [ 1 ] Major [ 3 ]
        Howard M. Lewis Ship made changes -
        Project Tapestry [ 10573 ] Tapestry 5 [ 12310833 ]
        Component/s tapestry-core [ 12311285 ]
        Affects Version/s 5.0.15 [ 12313350 ]
        Key TAPESTRY-2675 TAP5-132
        Howard M. Lewis Ship made changes -
        Affects Version/s 5.0.15 [ 12313429 ]
        Howard M. Lewis Ship made changes -
        Assignee Howard M. Lewis Ship [ hlship ]
        Howard M. Lewis Ship made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Howard M. Lewis Ship made changes -
        Resolution Fixed [ 1 ]
        Fix Version/s 5.0.16 [ 12313427 ]
        Status In Progress [ 3 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open In Progress In Progress
        3d 4h 58m 1 Howard M. Lewis Ship 19/Sep/08 05:14
        In Progress In Progress Closed Closed
        1m 36s 1 Howard M. Lewis Ship 19/Sep/08 05:15

          People

          • Assignee:
            Howard M. Lewis Ship
            Reporter:
            Filip S. Adamsen
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development